Skip to content

Commit 3e96e04

Browse files
committed
Move package handling before super call
1 parent 5cc0e21 commit 3e96e04

File tree

2 files changed

+16
-14
lines changed

2 files changed

+16
-14
lines changed

src/main/java/io/swagger/codegen/languages/php/PhpClientCodegen.java

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -209,20 +209,6 @@ public String getHelp() {
209209

210210
@Override
211211
public void processOpts() {
212-
super.processOpts();
213-
214-
if (additionalProperties.containsKey(PACKAGE_PATH)) {
215-
this.setPackagePath((String) additionalProperties.get(PACKAGE_PATH));
216-
} else {
217-
additionalProperties.put(PACKAGE_PATH, packagePath);
218-
}
219-
220-
if (additionalProperties.containsKey(SRC_BASE_PATH)) {
221-
this.setSrcBasePath((String) additionalProperties.get(SRC_BASE_PATH));
222-
} else {
223-
additionalProperties.put(SRC_BASE_PATH, srcBasePath);
224-
}
225-
226212
if (additionalProperties.containsKey(CodegenConstants.INVOKER_PACKAGE)) {
227213
this.setInvokerPackage((String) additionalProperties.get(CodegenConstants.INVOKER_PACKAGE));
228214

@@ -251,6 +237,20 @@ public void processOpts() {
251237
additionalProperties.put(COMPOSER_PROJECT_NAME, composerProjectName);
252238
}
253239

240+
super.processOpts();
241+
242+
if (additionalProperties.containsKey(PACKAGE_PATH)) {
243+
this.setPackagePath((String) additionalProperties.get(PACKAGE_PATH));
244+
} else {
245+
additionalProperties.put(PACKAGE_PATH, packagePath);
246+
}
247+
248+
if (additionalProperties.containsKey(SRC_BASE_PATH)) {
249+
this.setSrcBasePath((String) additionalProperties.get(SRC_BASE_PATH));
250+
} else {
251+
additionalProperties.put(SRC_BASE_PATH, srcBasePath);
252+
}
253+
254254
if (additionalProperties.containsKey(CodegenConstants.GIT_USER_ID)) {
255255
this.setGitUserId((String) additionalProperties.get(CodegenConstants.GIT_USER_ID));
256256
} else {

src/test/java/io/swagger/codegen/languages/php/PhpClientCodegenTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ public void testInitialValues() throws Exception {
1818
Assert.assertEquals(codegen.invokerPackage, "Swagger\\Client");
1919
Assert.assertEquals(codegen.additionalProperties().get(CodegenConstants.INVOKER_PACKAGE), "Swagger\\Client");
2020
Assert.assertEquals(codegen.getSortParamsByRequiredFlag(), Boolean.TRUE);
21+
Assert.assertEquals(codegen.additionalProperties().get(CodegenConstants.SORT_PARAMS_BY_REQUIRED_FLAG), Boolean.TRUE);
2122
Assert.assertEquals(codegen.getHideGenerationTimestamp(), Boolean.TRUE);
2223
Assert.assertEquals(codegen.additionalProperties().get(CodegenConstants.HIDE_GENERATION_TIMESTAMP), Boolean.TRUE);
2324
}
@@ -39,6 +40,7 @@ public void testSetters() throws Exception {
3940
Assert.assertEquals(codegen.invokerPackage, "My\\Client\\Invoker");
4041
Assert.assertEquals(codegen.additionalProperties().get(CodegenConstants.INVOKER_PACKAGE), "My\\Client\\Invoker");
4142
Assert.assertEquals(codegen.getSortParamsByRequiredFlag(), Boolean.FALSE);
43+
Assert.assertEquals(codegen.additionalProperties().get(CodegenConstants.SORT_PARAMS_BY_REQUIRED_FLAG), Boolean.FALSE);
4244
Assert.assertEquals(codegen.getHideGenerationTimestamp(), Boolean.FALSE);
4345
Assert.assertEquals(codegen.additionalProperties().get(CodegenConstants.HIDE_GENERATION_TIMESTAMP), Boolean.FALSE);
4446
}

0 commit comments

Comments
 (0)