-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat: async fragments #16542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: async fragments #16542
+142
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 88e4fb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
6 tasks
Rich-Harris
reviewed
Aug 6, 2025
Merged
Rich-Harris
reviewed
Aug 6, 2025
packages/svelte/src/compiler/phases/3-transform/client/visitors/AwaitExpression.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Rich Harris <[email protected]>
Rich-Harris
approved these changes
Aug 6, 2025
Rich-Harris
reviewed
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, not every part of your component can be async— child fragments can't be. A fragment is the children inside of a block, such as an
{#if }
block. Most fragments are compiled to synchronous functions. Since template expressions are individually compiled to functions that are either async or sync depending on their values, they can be async inside synchronous fragments. However, other things, such as{@const }
, can't be async, since you can't have await expressions inside synchronous functions.This fixes that. Additionally, this makes certain features, such as variable declarations in markup, much easier to implement.
Closes #16462
Supersedes #16463
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint