Skip to content

Conversation

@teemingc
Copy link
Member

@teemingc teemingc commented Nov 11, 2025

This PR separates the client-side page preloading logic into its own module, which is dynamically imported after the app has started. However, I'm not sure if the trade-off is worth it, or rather, I'm not sure how to measure the impact of this.

Pros:

  1. 300 bytes less transfer size if your browser supports data saving mode and its enabled
  2. Less code to parse before the page loads?

Cons:

  1. 1 KB more transfer size with data saving mode off or unsupported
  2. Also, an additional network request for loading the preload code separately

Turns out the transfer size of the client module with the preload code in the same chunk is smaller than having both in separate chunks.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2025

🦋 Changeset detected

Latest commit: 3735275

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@teemingc teemingc marked this pull request as ready for review November 12, 2025 17:20
@teemingc teemingc added the needs-decision Not sure if we want to do this yet, also design work needed label Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-decision Not sure if we want to do this yet, also design work needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants