feat: use vlq instead of base64 for encoding/decoding

Author: Rich-Harris

.changeset/famous-words-invite.md

@@ -0,0 +1,5 @@
+---
+'devalue': minor
+---
+
+feat: use vlq instead of base64 for encoding/decoding

package.json

@@ -34,5 +34,8 @@
 	},
 	"license": "MIT",
 	"type": "module",
-	"packageManager": "[email protected]"
+	"packageManager": "[email protected]",
+	"dependencies": {
+		"vlq": "^2.0.4"
+	}
 }

pnpm-lock.yaml

@@ -1,4 +1,5 @@
 import { decode64 } from './base64.js';
+import * as vlq from 'vlq';
 import {
 	HOLE,
 	NAN,
@@ -125,9 +126,7 @@ export function unflatten(parsed, revivers) {
 					}
 
 					case 'ArrayBuffer': {
-						const base64 = value[1];
-						const arraybuffer = decode64(base64);
-						hydrated[index] = arraybuffer;
+						hydrated[index] = new Uint8Array(vlq.decode(value[1])).buffer;
 						break;
 					}
 

src/parse.js

@@ -1,3 +1,4 @@
+import * as vlq from 'vlq';
 import {
 	DevalueError,
 	enumerable_symbols,
@@ -177,11 +178,7 @@ export function stringify(value, reducers) {
 				}
 
 				case 'ArrayBuffer': {
-					/** @type {ArrayBuffer} */
-					const arraybuffer = thing;
-					const base64 = encode64(arraybuffer);
-
-					str = `["ArrayBuffer","${base64}"]`;
+					str = `["ArrayBuffer","${vlq.encode(new Uint8Array(thing))}"]`;
 					break;
 				}
 

src/stringify.js

@@ -172,13 +172,13 @@ const fixtures = {
 			name: 'Uint8Array',
 			value: new Uint8Array([1, 2, 3]),
 			js: 'new Uint8Array([1,2,3])',
-			json: '[["Uint8Array",1],["ArrayBuffer","AQID"]]'
+			json: '[["Uint8Array",1],["ArrayBuffer","CEG"]]'
 		},
 		{
 			name: 'ArrayBuffer',
 			value: new Uint8Array([1, 2, 3]).buffer,
 			js: 'new Uint8Array([1,2,3]).buffer',
-			json: '[["ArrayBuffer","AQID"]]'
+			json: '[["ArrayBuffer","CEG"]]'
 		},
 		{
 			name: 'URL',
@@ -198,7 +198,7 @@ const fixtures = {
 			name: 'Sliced typed array',
 			value: new Uint16Array([10, 20, 30, 40]).subarray(1, 3),
 			js: 'new Uint16Array([10,20,30,40]).subarray(1,3)',
-			json: '[["Uint16Array",1,1,3],["ArrayBuffer","CgAUAB4AKAA="]]'
+			json: '[["Uint16Array",1,1,3],["ArrayBuffer","UAoBA8BAwCA"]]'
 		},
 		{
 			name: 'Temporal.Duration',
@@ -478,7 +478,7 @@ const fixtures = {
 				return [uint8, uint16];
 			})(),
 			js: '(function(a){return [new Uint8Array([a]),new Uint16Array([a])]}(new Uint8Array([0,1,2,3,4,5,6,7,8,9]).buffer))',
-			json: '[[1,3],["Uint8Array",2],["ArrayBuffer","AAECAwQFBgcICQ=="],["Uint16Array",2]]',
+			json: '[[1,3],["Uint8Array",2],["ArrayBuffer","ACEGIKMOQS"],["Uint16Array",2]]',
 			validate: ([uint8, uint16]) => {
 				return uint8.buffer === uint16.buffer;
 			}