asserting number of events

sv3ndk · sv3ndk · commit 7aea25647379 · 2024-09-01T15:33:56.000+02:00
diff --git a/.github/workflows/dev.yaml b/.github/workflows/dev.yaml
@@ -8,6 +8,7 @@ jobs:
   deploy:
     # this prevents concurrent builds since we are deploying to the same environment
     concurrency: dev-environment
+    timeout-minutes: 20
 
     runs-on: ubuntu-24.04
 
diff --git a/tests/end-to-end/steps/e2e_utils.py b/tests/end-to-end/steps/e2e_utils.py
@@ -113,7 +113,7 @@ def temporary_queue_subscribed_to_event_bus(event_bus_name: str, event_pattern:
 
         # not sure why, but even when marked as "ENABLED", we sometimes miss the first events
         # => wait a bit more, which likely makes the test flaky and unnecessarily slow :(
-        time.sleep(10)
+        time.sleep(20)
 
         yield tmp_queue
 
diff --git a/tests/end-to-end/steps/test_orders_scenarios.py b/tests/end-to-end/steps/test_orders_scenarios.py
@@ -76,6 +76,8 @@ def expect_order_event_in_event_bus_probe(restaurant_name: str, event_bus_probe_
     )
     print(f"events received {events}")
 
+    assert len(events) == 2
+
     # sort events by detail-type to make the test deterministic since EventBridge does not guarantee order
     events=sorted(events, key=lambda x: x["detail-type"])
 

Original file line number	Diff line number	Diff line change
`@@ -76,6 +76,8 @@ def expect_order_event_in_event_bus_probe(restaurant_name: str, event_bus_probe_`
`76`	`76`	`)`
`77`	`77`	`print(f"events received {events}")`
`78`	`78`
	`79`	`+ assert len(events) == 2`
	`80`	`+`
`79`	`81`	`# sort events by detail-type to make the test deterministic since EventBridge does not guarantee order`
`80`	`82`	`events=sorted(events, key=lambda x: x["detail-type"])`
`81`	`83`