Skip to content

Commit 0f772a9

Browse files
committed
removes explicit alarm name
1 parent 39c9e84 commit 0f772a9

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

cdk/app.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
scope=app,
3232
construct_id=f"Event{feature_name}",
3333
service_name=service_name,
34+
feature_name=feature_name,
3435
maturity_level=maturity_level,
3536
idempotency_table=db_stack.idempotency_table,
3637
)

cdk/event_stack.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ def __init__(
2525
construct_id: str,
2626

2727
service_name: str,
28+
feature_name: str,
2829
maturity_level: str,
2930
idempotency_table: Table,
3031

@@ -84,7 +85,7 @@ def __init__(
8485
on_failure_alarm = aws_cloudwatch.Alarm(
8586
scope=self,
8687
id="OnFailureQueueAlarm",
87-
alarm_name=f"[{maturity_level}][NotifyRestaurant function] Failed events detected in OnFailure destination",
88+
# alarm_name=f"[{maturity_level}][NotifyRestaurant function] Failed events detected in OnFailure destination",
8889
metric=restaurant_notification_error_queue.metric_approximate_number_of_messages_visible(),
8990
comparison_operator=aws_cloudwatch.ComparisonOperator.GREATER_THAN_THRESHOLD,
9091
threshold=0,
@@ -96,7 +97,7 @@ def __init__(
9697
destination_delivery_alarm = aws_cloudwatch.Alarm(
9798
scope=self,
9899
id="DestinationDeliveryFailuresAlarm",
99-
alarm_name=f"[{maturity_level}][NotifyRestaurant function] Failed to deliver failed events to OnFailure destination",
100+
# alarm_name=f"[{maturity_level}][NotifyRestaurant function] Failed to deliver failed events to OnFailure destination",
100101
metric=notify_restaurant_fn.metric("DestinationDeliveryFailures"),
101102
comparison_operator=aws_cloudwatch.ComparisonOperator.GREATER_THAN_THRESHOLD,
102103
threshold=0,

0 commit comments

Comments
 (0)