- [+] add & use prop_test.go for Piece Attributes testing

Author: suntong

cascadia_test.go

@@ -549,98 +549,3 @@ var selectorTests = []selectorTest{
 		},
 	},
 }
-
-type PieceAttrTest struct {
-	HTML, selector string
-	results        []string
-	piece          OutputStyleMap
-}
-
-var PieceAttrTests = []PieceAttrTest{
-	{
-		`<ul>
-			<li><a id="a1" href="http://www.google.com/finance"/>
-			<li><a id="a2" href="http://finance.yahoo.com/"/>
-			<li><a id="a3" href="https://www.google.com/news"></a>
-			<li><a id="a4" href="http://news.yahoo.com"/>
-		</ul>`,
-		`li`,
-		[]string{
-			`id,`,
-			`a1,`,
-			`a2,`,
-			`a3,`,
-			`a4,`,
-		},
-		OutputStyleMap{
-			[]string{"id"},
-			map[string]string{"id": "a"},
-			map[string]OutputStyle{"id": OutputStyleATTR},
-			map[string]string{"id": "id"},
-		},
-	},
-	{
-		`<ul>
-			<li><a id="a1" href="http://www.google.com/finance"/>
-			<li><a id="a2" href="http://finance.yahoo.com/"/>
-			<li><a id="a3" href="https://www.google.com/news"></a>
-			<li><a id="a4" href="http://news.yahoo.com"/>
-		</ul>`,
-		`li`,
-		[]string{
-			`href2,`,
-			`,`,
-			`,`,
-			`,`,
-			`,`,
-		},
-		OutputStyleMap{
-			[]string{"href2"},
-			map[string]string{"href2": "a"},
-			map[string]OutputStyle{"href2": OutputStyleATTR},
-			map[string]string{"href2": "href2"},
-		},
-	},
-	{
-		`<ul>
-			<li><a id="a1" href="http://www.google.com/finance"/>
-			<li><a id="a2" href="http://finance.yahoo.com/"/>
-			<li><a id="a3" href="https://www.google.com/news"></a>
-			<li><a id="a4" href="http://news.yahoo.com"/>
-		</ul>`,
-		`li`,
-		[]string{
-			`href,`,
-			`http://www.google.com/finance,`,
-			`http://finance.yahoo.com/,`,
-			`https://www.google.com/news,`,
-			`http://news.yahoo.com,`,
-		},
-		OutputStyleMap{
-			[]string{"href"},
-			map[string]string{"href": "a"},
-			map[string]OutputStyle{"href": OutputStyleATTR},
-			map[string]string{"href": "href"},
-		},
-	},
-}
-
-func TestPieceAttr(t *testing.T) {
-	for _, test := range PieceAttrTests {
-		buf := bytes.NewBufferString("")
-		Opts.CSS, Opts.Piece, Opts.Deli,
-			Opts.WrapHTML, Opts.TextOut, Opts.TextRaw, Opts.Quiet =
-			[]string{test.selector}, test.piece, ",",
-			false, false, false, false
-		Cascadia(strings.NewReader(test.HTML), buf, Opts)
-		got := buf.String()
-		if len(got) == 0 && len(test.results) == 0 {
-			// correct
-			continue
-		}
-		want := strings.Join(test.results, "\n") + "\n"
-		if got != want {
-			t.Errorf("wanted %s, got %s instead", want, got)
-		}
-	}
-}

piece_test.go

@@ -0,0 +1,19 @@
+package main_test
+
+import (
+	"testing"
+)
+
+func TestPieceAttr(t *testing.T) {
+	testCases(t, "Piece Attributes", []testCase{
+		{"id",
+			[]string{"-i", "opt_piece_attr.html", "-o", "-c", "li", "-p", "url=attr[id]:a"},
+		},
+		{"href",
+			[]string{"-i", "opt_piece_attr.html", "-o", "-c", "li", "-p", "url=attr[href]:a"},
+		},
+		//{"both_fields",},
+		//{"noexist"},
+		//{},
+	})
+}

prop_test.go

@@ -0,0 +1,73 @@
+package main_test
+
+import (
+	"bytes"
+	"os"
+	"os/exec"
+	"strings"
+	"testing"
+)
+
+const (
+	dirTest = "test/"
+	cmdTest = "../cascadia"
+	extRef  = ".ref" // extension for reference file
+	extGot  = ".got" // extension for generated file
+)
+
+// testIt runs @cmdTest with @argv and compares the generated
+// output for @name with the corresponding @extRef
+func testIt(t *testing.T, name string, argv ...string) {
+	var (
+		diffOut         bytes.Buffer
+		generatedOutput = name + extGot
+		cmd             = exec.Command(cmdTest, argv...)
+	)
+
+	t.Logf("Testing %s:\n\t%s %s\n", name, cmdTest, strings.Join(argv, " "))
+
+	// open the out file for writing
+	outfile, err := os.Create(generatedOutput)
+	if err != nil {
+		t.Errorf("write error [%s: %s] %s.", name, argv, err)
+	}
+	defer outfile.Close()
+	cmd.Stdout = outfile
+
+	err = cmd.Start()
+	if err != nil {
+		t.Errorf("start error [%s: %s] %s.", name, argv, err)
+	}
+	err = cmd.Wait()
+	if err != nil {
+		t.Errorf("exit error [%s: %s] %s.", name, argv, err)
+	}
+
+	cmd = exec.Command("diff", "-U1", name+extRef, generatedOutput)
+	cmd.Stdout = &diffOut
+
+	err = cmd.Start()
+	if err != nil {
+		t.Errorf("start error %s [%s: %s]", err, name, argv)
+	}
+	err = cmd.Wait()
+	if err != nil {
+		t.Errorf("cmp error %s [%s: %s]\n%s", err, name, argv, diffOut.String())
+	}
+	//os.Remove(generatedOutput)
+}
+
+type testCase struct {
+	name string
+	args []string
+}
+
+func testCases(t *testing.T, name string, testData []testCase) {
+	t.Logf("\n\n== Testing %s\n\n", name)
+	os.Chdir(dirTest)
+
+	for _, tc := range testData {
+		testIt(t, tc.name, tc.args...)
+	}
+
+}

test/.gitignore

@@ -0,0 +1 @@
+*.got

test/href.ref

@@ -0,0 +1,6 @@
+url	
+http://www.google.com/finance	
+http://finance.yahoo.com/	
+https://www.google.com/news	
+http://news.yahoo.com	
+

test/id.ref

@@ -0,0 +1,6 @@
+url	
+a1	
+a2	
+a3	
+a4	
+

test/opt_piece_attr.html

@@ -0,0 +1,6 @@
+<ul>
+                <li><a id="a1" href="http://www.google.com/finance"/>
+                <li><a id="a2" href="http://finance.yahoo.com/"/>
+                <li><a id="a3" href="https://www.google.com/news"></a>
+                <li><a id="a4" href="http://news.yahoo.com"/>
+</ul>