Set active to true for new Link payment details (#11279)

tillh-stripe · web-flow · commit e6197afafd27 · 2025-08-06T15:07:22.000-07:00
diff --git a/payments-model/src/main/java/com/stripe/android/model/ConsumerPaymentDetailsCreateParams.kt b/payments-model/src/main/java/com/stripe/android/model/ConsumerPaymentDetailsCreateParams.kt
@@ -18,13 +18,12 @@ sealed interface ConsumerPaymentDetailsCreateParams : StripeParamsModel, Parcela
     data class Card(
         private val cardPaymentMethodCreateParamsMap: Map<String, @RawValue Any>,
         private val email: String,
-        private val active: Boolean,
     ) : ConsumerPaymentDetailsCreateParams {
 
         override fun toParamMap(): Map<String, Any> {
             val params = mutableMapOf<String, Any>(
                 "type" to "card",
-                "active" to active,
+                "active" to true,
                 LINK_PARAM_BILLING_EMAIL_ADDRESS to email,
             )
 
diff --git a/payments-model/src/test/java/com/stripe/android/model/ConsumerPaymentDetailsCreateParamsTest.kt b/payments-model/src/test/java/com/stripe/android/model/ConsumerPaymentDetailsCreateParamsTest.kt
@@ -30,7 +30,6 @@ class ConsumerPaymentDetailsCreateParamsTest {
                     )
                 ),
                 email = "email@stripe.com",
-                active = false,
             ).toParamMap()
         ).isEqualTo(
             mapOf(
@@ -45,7 +44,7 @@ class ConsumerPaymentDetailsCreateParamsTest {
                     "country_code" to "US",
                     "postal_code" to "12345"
                 ),
-                "active" to false,
+                "active" to true,
             )
         )
     }
@@ -75,7 +74,6 @@ class ConsumerPaymentDetailsCreateParamsTest {
                     )
                 ),
                 email = "email@stripe.com",
-                active = false,
             ).toParamMap()
         ).isEqualTo(
             mapOf(
@@ -91,7 +89,7 @@ class ConsumerPaymentDetailsCreateParamsTest {
                     "country_code" to "US",
                     "postal_code" to "12345"
                 ),
-                "active" to false,
+                "active" to true,
             )
         )
     }
diff --git a/payments-model/src/test/java/com/stripe/android/repository/ConsumersApiServiceImplTest.kt b/payments-model/src/test/java/com/stripe/android/repository/ConsumersApiServiceImplTest.kt
@@ -225,7 +225,7 @@ class ConsumersApiServiceImplTest {
             header("User-Agent", "Stripe/v1 ${StripeSdkVersion.VERSION}"),
             bodyPart(urlEncode("credentials[consumer_session_client_secret]"), "secret"),
             bodyPart("type", "card"),
-            bodyPart("active", "false"),
+            bodyPart("active", "true"),
             bodyPart("billing_email_address", urlEncode(email)),
             bodyPart(urlEncode("card[number]"), "4242424242424242"),
             bodyPart(urlEncode("card[exp_month]"), "12"),
@@ -257,7 +257,6 @@ class ConsumersApiServiceImplTest {
             paymentDetailsCreateParams = ConsumerPaymentDetailsCreateParams.Card(
                 cardPaymentMethodCreateParamsMap = paymentMethodCreateParams,
                 email = email,
-                active = false,
             ),
             requestSurface = requestSurface,
             requestOptions = DEFAULT_OPTIONS,
@@ -279,7 +278,7 @@ class ConsumersApiServiceImplTest {
             header("User-Agent", "Stripe/v1 ${StripeSdkVersion.VERSION}"),
             bodyPart(urlEncode("credentials[consumer_session_client_secret]"), "secret"),
             bodyPart("type", "card"),
-            bodyPart("active", "false"),
+            bodyPart("active", "true"),
             bodyPart("billing_email_address", urlEncode(email)),
             bodyPart(urlEncode("card[number]"), "4242424242424242"),
             bodyPart(urlEncode("card[exp_month]"), "12"),
@@ -315,7 +314,6 @@ class ConsumersApiServiceImplTest {
             paymentDetailsCreateParams = ConsumerPaymentDetailsCreateParams.Card(
                 cardPaymentMethodCreateParamsMap = paymentMethodCreateParams,
                 email = email,
-                active = false,
             ),
             requestSurface = requestSurface,
             requestOptions = DEFAULT_OPTIONS,
diff --git a/paymentsheet/src/main/java/com/stripe/android/link/account/DefaultLinkAccountManager.kt b/paymentsheet/src/main/java/com/stripe/android/link/account/DefaultLinkAccountManager.kt
@@ -288,7 +288,6 @@ internal class DefaultLinkAccountManager @Inject constructor(
                     stripeIntent = config.stripeIntent,
                     consumerSessionClientSecret = account.clientSecret,
                     consumerPublishableKey = account.consumerPublishableKey.takeIf { !config.passthroughModeEnabled },
-                    active = config.passthroughModeEnabled,
                 ).onSuccess {
                     errorReporter.report(ErrorReporter.SuccessEvent.LINK_CREATE_CARD_SUCCESS)
                 }
diff --git a/paymentsheet/src/main/java/com/stripe/android/link/repositories/LinkApiRepository.kt b/paymentsheet/src/main/java/com/stripe/android/link/repositories/LinkApiRepository.kt
@@ -178,14 +178,12 @@ internal class LinkApiRepository @Inject constructor(
         stripeIntent: StripeIntent,
         consumerSessionClientSecret: String,
         consumerPublishableKey: String?,
-        active: Boolean,
     ): Result<LinkPaymentDetails.New> = withContext(workContext) {
         consumersApiService.createPaymentDetails(
             consumerSessionClientSecret = consumerSessionClientSecret,
             paymentDetailsCreateParams = ConsumerPaymentDetailsCreateParams.Card(
                 cardPaymentMethodCreateParamsMap = paymentMethodCreateParams.toParamMap(),
                 email = userEmail,
-                active = active,
             ),
             requestSurface = REQUEST_SURFACE,
             requestOptions = buildRequestOptions(consumerPublishableKey),
diff --git a/paymentsheet/src/main/java/com/stripe/android/link/repositories/LinkRepository.kt b/paymentsheet/src/main/java/com/stripe/android/link/repositories/LinkRepository.kt
@@ -92,7 +92,6 @@ internal interface LinkRepository {
         stripeIntent: StripeIntent,
         consumerSessionClientSecret: String,
         consumerPublishableKey: String?,
-        active: Boolean,
     ): Result<LinkPaymentDetails.New>
 
     suspend fun createBankAccountPaymentDetails(
diff --git a/paymentsheet/src/test/java/com/stripe/android/link/account/DefaultLinkAccountManagerTest.kt b/paymentsheet/src/test/java/com/stripe/android/link/account/DefaultLinkAccountManagerTest.kt
@@ -482,7 +482,6 @@ class DefaultLinkAccountManagerTest {
                 stripeIntent: StripeIntent,
                 consumerSessionClientSecret: String,
                 consumerPublishableKey: String?,
-                active: Boolean
             ): Result<LinkPaymentDetails.New> {
                 val details = result.first()
                 if (result.size > 1) {
diff --git a/paymentsheet/src/test/java/com/stripe/android/link/repositories/FakeLinkRepository.kt b/paymentsheet/src/test/java/com/stripe/android/link/repositories/FakeLinkRepository.kt
@@ -129,7 +129,6 @@ internal open class FakeLinkRepository : LinkRepository {
         stripeIntent: StripeIntent,
         consumerSessionClientSecret: String,
         consumerPublishableKey: String?,
-        active: Boolean
     ) = createCardPaymentDetailsResult
 
     override suspend fun createBankAccountPaymentDetails(
diff --git a/paymentsheet/src/test/java/com/stripe/android/link/repositories/LinkApiRepositoryTest.kt b/paymentsheet/src/test/java/com/stripe/android/link/repositories/LinkApiRepositoryTest.kt
@@ -279,7 +279,6 @@ class LinkApiRepositoryTest {
             stripeIntent = paymentIntent,
             consumerSessionClientSecret = secret,
             consumerPublishableKey = consumerKey,
-            active = false,
         )
 
         verify(consumersApiService).createPaymentDetails(
@@ -297,7 +296,7 @@ class LinkApiRepositoryTest {
                         "country_code" to "US",
                         "postal_code" to "12345"
                     ),
-                    "active" to false,
+                    "active" to true,
                 )
             },
             requestSurface = eq("android_payment_element"),
@@ -330,7 +329,6 @@ class LinkApiRepositoryTest {
                 stripeIntent = paymentIntent,
                 consumerSessionClientSecret = secret,
                 consumerPublishableKey = consumerKey,
-                active = false,
             ).getOrThrow()
 
             assertThat(linkDetails.paymentMethodCreateParams.allowRedisplay).isEqualTo(allowRedisplay)
@@ -349,7 +347,6 @@ class LinkApiRepositoryTest {
                 stripeIntent = paymentIntent,
                 consumerSessionClientSecret = secret,
                 consumerPublishableKey = null,
-                active = false,
             )
 
             verify(consumersApiService).createPaymentDetails(
@@ -367,7 +364,7 @@ class LinkApiRepositoryTest {
                             "country_code" to "US",
                             "postal_code" to "12345"
                         ),
-                        "active" to false,
+                        "active" to true,
                     )
                 },
                 requestSurface = eq("android_payment_element"),
@@ -395,7 +392,6 @@ class LinkApiRepositoryTest {
             stripeIntent = paymentIntent,
             consumerSessionClientSecret = consumerSessionSecret,
             consumerPublishableKey = null,
-            active = false,
         )
 
         assertThat(result.isSuccess).isTrue()
@@ -443,7 +439,6 @@ class LinkApiRepositoryTest {
             stripeIntent = paymentIntent,
             consumerSessionClientSecret = "secret",
             consumerPublishableKey = null,
-            active = false,
         )
         val loggedErrors = errorReporter.getLoggedErrors()
 
diff --git a/paymentsheet/src/test/java/com/stripe/android/link/ui/paymentmethod/SupportedPaymentMethodTest.kt b/paymentsheet/src/test/java/com/stripe/android/link/ui/paymentmethod/SupportedPaymentMethodTest.kt
@@ -28,7 +28,6 @@ class SupportedPaymentMethodTest {
             ConsumerPaymentDetailsCreateParams.Card(
                 cardPaymentMethodCreateParamsMap = paymentMethodCreateParams,
                 email = "email@test.com",
-                active = false,
             ).toParamMap()
         ).isEqualTo(
             mapOf(
@@ -43,7 +42,7 @@ class SupportedPaymentMethodTest {
                     "country_code" to "US",
                     "postal_code" to "12345"
                 ),
-                "active" to false,
+                "active" to true,
             )
         )
     }

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,6 @@ class ConsumerPaymentDetailsCreateParamsTest {`
`30`	`30`	`)`
`31`	`31`	`),`
`32`	`32`	`email = "[email protected]",`
`33`		`- active = false,`
`34`	`33`	`).toParamMap()`
`35`	`34`	`).isEqualTo(`
`36`	`35`	`mapOf(`
`@@ -45,7 +44,7 @@ class ConsumerPaymentDetailsCreateParamsTest {`
`45`	`44`	`"country_code" to "US",`
`46`	`45`	`"postal_code" to "12345"`
`47`	`46`	`),`
`48`		`- "active" to false,`
	`47`	`+ "active" to true,`
`49`	`48`	`)`
`50`	`49`	`)`
`51`	`50`	`}`
`@@ -75,7 +74,6 @@ class ConsumerPaymentDetailsCreateParamsTest {`
`75`	`74`	`)`
`76`	`75`	`),`
`77`	`76`	`email = "[email protected]",`
`78`		`- active = false,`
`79`	`77`	`).toParamMap()`
`80`	`78`	`).isEqualTo(`
`81`	`79`	`mapOf(`
`@@ -91,7 +89,7 @@ class ConsumerPaymentDetailsCreateParamsTest {`
`91`	`89`	`"country_code" to "US",`
`92`	`90`	`"postal_code" to "12345"`
`93`	`91`	`),`
`94`		`- "active" to false,`
	`92`	`+ "active" to true,`
`95`	`93`	`)`
`96`	`94`	`)`
`97`	`95`	`}`
Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,6 @@ internal class DefaultLinkAccountManager @Inject constructor(`
`288`	`288`	`stripeIntent = config.stripeIntent,`
`289`	`289`	`consumerSessionClientSecret = account.clientSecret,`
`290`	`290`	`consumerPublishableKey = account.consumerPublishableKey.takeIf { !config.passthroughModeEnabled },`
`291`		`- active = config.passthroughModeEnabled,`
`292`	`291`	`).onSuccess {`
`293`	`292`	`errorReporter.report(ErrorReporter.SuccessEvent.LINK_CREATE_CARD_SUCCESS)`
`294`	`293`	`}`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,6 @@ class SupportedPaymentMethodTest {`
`28`	`28`	`ConsumerPaymentDetailsCreateParams.Card(`
`29`	`29`	`cardPaymentMethodCreateParamsMap = paymentMethodCreateParams,`
`30`	`30`	`email = "[email protected]",`
`31`		`- active = false,`
`32`	`31`	`).toParamMap()`
`33`	`32`	`).isEqualTo(`
`34`	`33`	`mapOf(`
`@@ -43,7 +42,7 @@ class SupportedPaymentMethodTest {`
`43`	`42`	`"country_code" to "US",`
`44`	`43`	`"postal_code" to "12345"`
`45`	`44`	`),`
`46`		`- "active" to false,`
	`45`	`+ "active" to true,`
`47`	`46`	`)`
`48`	`47`	`)`
`49`	`48`	`}`