Qt: Use header resize mode for disc windows

Author: stenzek

src/duckstation-qt/isobrowserwindow.cpp

@@ -13,7 +13,6 @@
 #include "common/log.h"
 #include "common/path.h"
 
-#include <QtCore/QTimer>
 #include <QtGui/QIcon>
 #include <QtWidgets/QFileDialog>
 #include <QtWidgets/QMenu>
@@ -27,6 +26,7 @@ ISOBrowserWindow::ISOBrowserWindow(QWidget* parent) : QWidget(parent)
 {
   m_ui.setupUi(this);
   m_ui.splitter->setSizes({200, 600});
+  QtUtils::SetColumnWidthsForTreeView(m_ui.fileView, {-1, 200, 100});
   setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint);
   enableUi(false);
 
@@ -81,18 +81,6 @@ bool ISOBrowserWindow::tryOpenFile(const QString& path, Error* error /*= nullptr
   return true;
 }
 
-void ISOBrowserWindow::resizeEvent(QResizeEvent* ev)
-{
-  QWidget::resizeEvent(ev);
-  resizeFileListColumns();
-}
-
-void ISOBrowserWindow::showEvent(QShowEvent* ev)
-{
-  QWidget::showEvent(ev);
-  resizeFileListColumns();
-}
-
 void ISOBrowserWindow::onOpenFileClicked()
 {
   const QString path = QFileDialog::getOpenFileName(
@@ -186,11 +174,6 @@ void ISOBrowserWindow::onFileContextMenuRequested(const QPoint& pos)
   menu.exec(m_ui.fileView->mapToGlobal(pos));
 }
 
-void ISOBrowserWindow::resizeFileListColumns()
-{
-  QtUtils::ResizeColumnsForTreeView(m_ui.fileView, {-1, 200, 100});
-}
-
 void ISOBrowserWindow::extractFile(const QString& path, IsoReader::ReadMode mode)
 {
   const std::string spath = path.toStdString();
@@ -365,7 +348,4 @@ void ISOBrowserWindow::populateFiles(const QString& path)
 
     add_entry(full_path, entry);
   }
-
-  // this is utter shit, the scrollbar visibility doesn't update in time, so we have to queue it.
-  QTimer::singleShot(20, Qt::CoarseTimer, this, &ISOBrowserWindow::resizeFileListColumns);
 }

src/duckstation-qt/isobrowserwindow.h

@@ -19,17 +19,12 @@ class ISOBrowserWindow : public QWidget
 
   bool tryOpenFile(const QString& path, Error* error = nullptr);
 
-protected:
-  void resizeEvent(QResizeEvent* ev);
-  void showEvent(QShowEvent* ev);
-
 private Q_SLOTS:
   void onOpenFileClicked();
   void onDirectoryItemClicked(QTreeWidgetItem* item, int column);
   void onFileItemActivated(QTreeWidgetItem* item, int column);
   void onFileItemSelectionChanged();
   void onFileContextMenuRequested(const QPoint& pos);
-  void resizeFileListColumns();
 
 private:
   void enableUi(bool enabled);

src/duckstation-qt/qtutils.cpp

@@ -165,6 +165,8 @@ static void SetColumnWidthForView(T* const view, QHeaderView* const header, cons
 
     column_index++;
   }
+
+  header->setStretchLastSection(false);
 }
 
 void QtUtils::ResizeColumnsForTableView(QTableView* view, const std::initializer_list<int>& widths)

src/duckstation-qt/selectdiscdialog.cpp

@@ -16,6 +16,7 @@
 SelectDiscDialog::SelectDiscDialog(const std::string& disc_set_name, QWidget* parent /* = nullptr */) : QDialog(parent)
 {
   m_ui.setupUi(this);
+  QtUtils::SetColumnWidthsForTreeView(m_ui.discList, {50, -1, 100});
   populateList(disc_set_name);
   updateStartEnabled();
 
@@ -27,13 +28,6 @@ SelectDiscDialog::SelectDiscDialog(const std::string& disc_set_name, QWidget* pa
 
 SelectDiscDialog::~SelectDiscDialog() = default;
 
-void SelectDiscDialog::resizeEvent(QResizeEvent* ev)
-{
-  QDialog::resizeEvent(ev);
-
-  QtUtils::ResizeColumnsForTreeView(m_ui.discList, {50, -1, 100});
-}
-
 void SelectDiscDialog::onListItemActivated(const QTreeWidgetItem* item)
 {
   if (!item)

src/duckstation-qt/selectdiscdialog.h

@@ -19,9 +19,6 @@ class SelectDiscDialog final : public QDialog
 
   ALWAYS_INLINE const std::string& getSelectedDiscPath() { return m_selected_path; }
 
-protected:
-  void resizeEvent(QResizeEvent* ev);
-
 private Q_SLOTS:
   void onListItemActivated(const QTreeWidgetItem* item);
   void updateStartEnabled();