Refactoring

Author: staudenmeir

src/Facades/Schema.php

@@ -61,31 +61,33 @@ public static function connection($name)
      */
     public static function getSchemaBuilder(Connection $connection)
     {
-        $driver = $connection->getDriverName();
-
-        switch ($driver) {
-            case 'mysql':
-                $connection->setSchemaGrammar($connection->withTablePrefix(new MySqlGrammar()));
-
-                return new MySqlBuilder($connection);
-            case 'mariadb':
-                $connection->setSchemaGrammar($connection->withTablePrefix(new MariaDbGrammar()));
-
-                return new MariaDbBuilder($connection);
-            case 'pgsql':
-                $connection->setSchemaGrammar($connection->withTablePrefix(new PostgresGrammar()));
-
-                return new PostgresBuilder($connection);
-            case 'sqlite':
-                $connection->setSchemaGrammar($connection->withTablePrefix(new SQLiteGrammar()));
-
-                return new SQLiteBuilder($connection);
-            case 'sqlsrv':
-                $connection->setSchemaGrammar($connection->withTablePrefix(new SqlServerGrammar()));
-
-                return new SqlServerBuilder($connection);
-        }
-
-        throw new RuntimeException('This database is not supported.'); // @codeCoverageIgnore
+        return match ($connection->getDriverName()) {
+            'mysql' => new MySqlBuilder(
+                $connection->setSchemaGrammar(
+                    $connection->withTablePrefix(new MySqlGrammar())
+                )
+            ),
+            'mariadb' => new MariaDbBuilder(
+                $connection->setSchemaGrammar(
+                    $connection->withTablePrefix(new MariaDbGrammar())
+                )
+            ),
+            'pgsql' => new PostgresBuilder(
+                $connection->setSchemaGrammar(
+                    $connection->withTablePrefix(new PostgresGrammar())
+                )
+            ),
+            'sqlite' => new SQLiteBuilder(
+                $connection->setSchemaGrammar(
+                    $connection->withTablePrefix(new SQLiteGrammar())
+                )
+            ),
+            'sqlsrv' => new SqlServerBuilder(
+                $connection->setSchemaGrammar(
+                    $connection->withTablePrefix(new SqlServerGrammar())
+                )
+            ),
+            default => throw new RuntimeException('This database is not supported.'), // @codeCoverageIgnore
+        };
     }
 }

src/Schema/Builders/ManagesViews.php

@@ -82,13 +82,13 @@ protected function stringifyBindings(array $bindings)
     {
         $bindings = $this->connection->prepareBindings($bindings);
 
-        foreach ($bindings as &$binding) {
+        foreach ($bindings as $key => $binding) {
             if (is_object($binding)) {
                 $binding = (string) $binding;
             }
 
             if (is_string($binding)) {
-                $binding = $this->connection->getPdo()->quote($binding);
+                $bindings[$key] = $this->connection->getPdo()->quote($binding);
             }
         }
 

src/Schema/Builders/PostgresBuilder.php

@@ -18,9 +18,9 @@ class PostgresBuilder extends Base
      */
     protected function stringifyBindings(array $bindings)
     {
-        foreach ($bindings as &$binding) {
+        foreach ($bindings as $key => $binding) {
             if (is_bool($binding)) {
-                $binding = $binding ? 'true' : 'false';
+                $bindings[$key] = $binding ? 'true' : 'false';
             }
         }