Skip to content

Conversation

@micieslak
Copy link
Member

What does the PR do

This PR reuses the QmlFilesServer created for Storybook to create stand-alone server configured to provide qml files and other resources for the actual app. It allows to avoid frequent and time-consuming re-deployments when only qml files were changed. What is needed is just app restart.

Affected areas

Mobile build script, Storybook (http server is a target within Storybook project)

Architecture compliance

Screencapture of the functionality

@micieslak micieslak requested review from a team, alexjba, caybro and noeliaSD as code owners August 11, 2025 08:36
@micieslak micieslak marked this pull request as draft August 11, 2025 08:36
@status-im-auto
Copy link
Member

status-im-auto commented Aug 11, 2025

Jenkins Builds

Click to see older builds (43)
Commit #️⃣ Finished (UTC) Duration Platform Result
9679d84 #1 2025-08-11 08:41:18 ~4 min macos/aarch64 📄log
✔️ 9679d84 #1 2025-08-11 08:43:30 ~6 min tests/nim 📄log
✔️ 9679d84 #1 2025-08-11 08:49:08 ~12 min tests/ui 📄log
✔️ 9679d84 #1 2025-08-11 08:49:44 ~12 min macos/aarch64 🍎dmg
✔️ 9679d84 #1 2025-08-11 08:52:21 ~15 min linux/x86_64 📦tgz
✔️ 9679d84 #1 2025-08-11 08:52:27 ~15 min linux/x86_64 📦tgz
✔️ 9679d84 pr18542 2025-08-11 09:04:34 ~12 min tests/e2e 📊rpt
✔️ 9679d84 pr18542 2025-08-11 09:05:12 ~12 min tests/e2e 📊rpt
✔️ 9679d84 #1 2025-08-11 09:11:21 ~34 min windows/x86_64 💿exe
ae6ea0b #2 2025-08-11 12:35:52 ~1 min macos/aarch64 📄log
ae6ea0b #2 2025-08-11 12:35:53 ~1 min macos/aarch64 📄log
✔️ ae6ea0b #2 2025-08-11 12:40:55 ~6 min tests/nim 📄log
✔️ ae6ea0b #2 2025-08-11 12:46:09 ~12 min tests/ui 📄log
✔️ ae6ea0b #2 2025-08-11 12:46:56 ~13 min linux/x86_64 📦tgz
✔️ ae6ea0b #2 2025-08-11 12:47:00 ~13 min linux/x86_64 📦tgz
✔️ ae6ea0b pr18542 2025-08-11 13:01:13 ~14 min tests/e2e 📊rpt
✔️ ae6ea0b pr18542 2025-08-11 13:01:29 ~14 min tests/e2e 📊rpt
565a38e #3 2025-08-11 12:51:31 ~2 min macos/aarch64 📄log
565a38e #3 2025-08-11 12:51:35 ~2 min macos/aarch64 📄log
✔️ 565a38e #3 2025-08-11 12:57:10 ~7 min tests/nim 📄log
✔️ 565a38e #3 2025-08-11 13:03:15 ~13 min tests/ui 📄log
✔️ 565a38e #3 2025-08-11 13:06:28 ~17 min linux/x86_64 📦tgz
✔️ 565a38e #3 2025-08-11 13:06:32 ~17 min linux/x86_64 📦tgz
✔️ 565a38e pr18542 2025-08-11 13:17:24 ~10 min tests/e2e 📊rpt
✔️ 565a38e pr18542 2025-08-11 13:17:24 ~10 min tests/e2e 📊rpt
✔️ 565a38e #3 2025-08-11 13:24:21 ~34 min windows/x86_64 💿exe
590b1b8 #4 2025-08-12 08:54:03 ~2 min macos/aarch64 📄log
590b1b8 #4 2025-08-12 08:54:04 ~2 min macos/aarch64 📄log
✔️ 590b1b8 #4 2025-08-12 08:59:03 ~7 min tests/nim 📄log
✔️ 590b1b8 #4 2025-08-12 09:04:45 ~12 min tests/ui 📄log
✔️ 590b1b8 #4 2025-08-12 09:05:15 ~13 min linux/x86_64 📦tgz
✔️ 590b1b8 #4 2025-08-12 09:07:46 ~15 min linux/x86_64 📦tgz
✔️ 590b1b8 pr18542 2025-08-12 09:16:11 ~10 min tests/e2e 📊rpt
✖️ 590b1b8 pr18542 2025-08-12 09:18:46 ~10 min tests/e2e 📊rpt
429cfba #5 2025-08-12 09:10:56 ~1 min macos/aarch64 📄log
✔️ 429cfba #5 2025-08-12 09:16:16 ~7 min tests/nim 📄log
✔️ 429cfba #5 2025-08-12 09:18:34 ~9 min macos/aarch64 🍎dmg
✔️ 429cfba #5 2025-08-12 09:21:25 ~12 min linux/x86_64 📦tgz
✔️ 429cfba #5 2025-08-12 09:21:32 ~12 min tests/ui 📄log
✔️ 429cfba #5 2025-08-12 09:25:24 ~16 min linux/x86_64 📦tgz
✔️ 429cfba pr18542 2025-08-12 09:32:17 ~10 min tests/e2e 📊rpt
✔️ 429cfba pr18542 2025-08-12 09:36:34 ~11 min tests/e2e 📊rpt
✔️ 429cfba #5 2025-08-12 09:43:53 ~34 min windows/x86_64 💿exe
Commit #️⃣ Finished (UTC) Duration Platform Result
1d3d2bf #6 2025-08-12 09:54:37 ~1 min macos/aarch64 📄log
✔️ 1d3d2bf #6 2025-08-12 10:00:11 ~7 min tests/nim 📄log
✔️ 1d3d2bf #6 2025-08-12 10:02:18 ~9 min macos/aarch64 🍎dmg
✔️ 1d3d2bf #6 2025-08-12 10:05:08 ~12 min linux/x86_64 📦tgz
✔️ 1d3d2bf #6 2025-08-12 10:05:35 ~12 min tests/ui 📄log
✔️ 1d3d2bf #6 2025-08-12 10:05:53 ~13 min linux/x86_64 📦tgz
✔️ 1d3d2bf pr18542 2025-08-12 10:16:23 ~11 min tests/e2e 📊rpt
✔️ 1d3d2bf pr18542 2025-08-12 10:17:41 ~11 min tests/e2e 📊rpt
✔️ 1d3d2bf #6 2025-08-12 10:23:51 ~31 min windows/x86_64 💿exe
✔️ 1d3d2bf #7 2025-08-13 12:55:09 ~8 min macos/aarch64 🍎dmg
✔️ c033779 #7 2025-08-27 09:20:15 ~7 min tests/nim 📄log
✔️ c033779 #7 2025-08-27 09:26:23 ~13 min linux/x86_64 📦tgz
✔️ c033779 #7 2025-08-27 09:26:38 ~13 min tests/ui 📄log
✔️ c033779 #7 2025-08-27 09:30:22 ~17 min macos/aarch64 🍎dmg
✔️ c033779 #7 2025-08-27 09:34:21 ~21 min linux/x86_64-nwaku 📦tgz
✔️ c033779 #8 2025-08-27 09:35:38 ~22 min macos/aarch64-nwaku 🍎dmg
✔️ c033779 pr18542 2025-08-27 09:44:29 ~17 min tests/e2e 📊rpt
✔️ c033779 #7 2025-08-27 09:48:10 ~35 min windows/x86_64 💿exe

@alexjba
Copy link
Contributor

alexjba commented Aug 11, 2025

image

@micieslak micieslak marked this pull request as ready for review August 11, 2025 12:54
@micieslak micieslak force-pushed the feat/issue-18466 branch 3 times, most recently from 429cfba to 1d3d2bf Compare August 12, 2025 09:52
@micieslak micieslak requested review from alexjba and caybro August 12, 2025 14:32
Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Khushboo-dev-cpp Khushboo-dev-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, pending testing for this PR.

@micieslak micieslak merged commit 1f1b653 into master Aug 28, 2025
9 checks passed
@micieslak micieslak deleted the feat/issue-18466 branch August 28, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants