fix oidc and token exchange config for k8s

[yrobla]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 19.14894% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.95%. Comparing base (d3ed163) to head (b56d807).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/runner/middleware.go	0.00%	15 Missing ⚠️
...d/thv-operator/pkg/controllerutil/tokenexchange.go	0.00%	11 Missing ⚠️
...v-operator/controllers/mcpremoteproxy_runconfig.go	33.33%	2 Missing and 2 partials ⚠️
...md/thv-operator/controllers/mcpserver_runconfig.go	33.33%	2 Missing and 2 partials ⚠️
pkg/runner/config_builder.go	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2537      +/-   ##
==========================================
- Coverage   55.99%   55.95%   -0.05%     
==========================================
  Files         316      316              
  Lines       29748    29766      +18     
==========================================
- Hits        16658    16655       -3     
- Misses      11636    11652      +16     
- Partials     1454     1459       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull Request Overview

This PR enables consuming the resource URL for CRD (Custom Resource Definition) configurations by introducing a mechanism to append middleware configurations incrementally in the operator context.

• Introduced WithAppendMiddlewareConfig function to append individual middleware configs instead of replacing the entire list
• Updated AddExternalAuthConfigOptions to use the append pattern for token exchange middleware
• Enhanced AddOIDCConfigOptions to create and append auth middleware configuration for OAuth discovery endpoint support

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
pkg/runner/config_builder.go	Added WithAppendMiddlewareConfig function to support incremental middleware configuration
cmd/thv-operator/pkg/controllerutil/tokenexchange.go	Changed to use WithAppendMiddlewareConfig instead of WithMiddlewareConfig to preserve existing middlewares
cmd/thv-operator/pkg/controllerutil/oidc.go	Added auth middleware creation to enable authInfoHandler for OAuth discovery endpoints and support ResourceURL field

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[yrobla]

@claude please review. wasn't there any other opportunity for code reuse, or any other optimization?

[claude]

Claude encountered an error —— View job

---

I'll analyze this and get back to you.

[JAORMX]

Uhm... shouldn't this come from the runconfig we form? Ideally it should already be formed that way from there.

[blkt]

I won't block this because I don't get the full scope of the change, but I'm a bit concerned by some of the added code, could you clarify the changes?

[Copilot]

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[JAORMX]

@yrobla could it be that we're not seeing yo the middleware correctly in the proxyrunner? Then the changes would go there instead of the general runner package cc @blkt @ChrisJBurns

[Copilot]

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[yrobla]

@yrobla could it be that we're not seeing yo the middleware correctly in the proxyrunner? Then the changes would go there instead of the general runner package cc @blkt @ChrisJBurns

proxyrunner should be picking the config from runconfig as well, right?

[Copilot]

Pull Request Overview

Copilot reviewed 16 out of 18 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.