Drop Python 3.9 support and test against 3.14 (#343)

* Drop Python 3.9 support and test against 3.14

Python 3.9 reaches end-of-life in October 2025, with Python 3.14
released in the same month.

* Update dependencies

* Fix new Ruff lints

Author: srstevenson

.github/workflows/ci.yml

@@ -12,11 +12,11 @@ jobs:
     strategy:
       matrix:
         python:
-          - "3.9"
           - "3.10"
           - "3.11"
           - "3.12"
           - "3.13"
+          - "3.14"
     env:
       UV_PYTHON: ${{ matrix.python }}
     steps:

.python-version

@@ -1 +1 @@
-3.9
+3.10

README.md

@@ -35,7 +35,7 @@ and accompanying [blog post][blog post].
 
 ## Installation
 
-nb-clean requires Python 3.9 or later. To run the latest release of nb-clean in
+nb-clean requires Python 3.10 or later. To run the latest release of nb-clean in
 an ephemeral virtual environment, use [uv]:
 
 ```bash

pyproject.toml

@@ -6,7 +6,7 @@ authors = [{ name = "Scott Stevenson", email = "[email protected]" }]
 readme = "README.md"
 license = "ISC"
 license-files = ["LICENSE"]
-requires-python = ">=3.9"
+requires-python = ">=3.10"
 keywords = ["jupyter", "notebook", "clean", "filter", "git"]
 classifiers = [
   "Development Status :: 5 - Production/Stable",
@@ -45,7 +45,7 @@ typeCheckingMode = "recommended"
 reportUnusedCallResult = false
 
 [tool.ruff]
-target-version = "py39"
+target-version = "py310"
 
 [tool.ruff.format]
 docstring-code-format = true

src/nb_clean/__init__.py

@@ -240,7 +240,7 @@ def check_notebook(
                 print(f"{prefix}: outputs")
                 is_clean = False
 
-    if remove_all_notebook_metadata and cast(dict[str, Any], notebook.metadata):  # pyright: ignore[reportExplicitAny]
+    if remove_all_notebook_metadata and cast("dict[str, Any]", notebook.metadata):  # pyright: ignore[reportExplicitAny]
         print(f"{filename}: metadata")
         is_clean = False
 

src/nb_clean/cli.py

@@ -137,10 +137,10 @@ def check(
 
     all_clean = True
     for input_ in processed_inputs:
-        name = "stdin" if input_ is sys.stdin else os.fspath(cast(Path, input_))
+        name = "stdin" if input_ is sys.stdin else os.fspath(cast("Path", input_))
 
         notebook = cast(
-            nbformat.NotebookNode,
+            "nbformat.NotebookNode",
             nbformat.read(input_, as_version=nbformat.NO_CONVERT),  # pyright: ignore[reportUnknownMemberType]
         )
         is_clean = nb_clean.check_notebook(
@@ -188,9 +188,9 @@ def clean(
         processed_inputs = [sys.stdin]
         outputs = [sys.stdout]
 
-    for input_, output in zip(processed_inputs, outputs):
+    for input_, output in zip(processed_inputs, outputs, strict=True):
         notebook = cast(
-            nbformat.NotebookNode,
+            "nbformat.NotebookNode",
             nbformat.read(input_, as_version=nbformat.NO_CONVERT),  # pyright: ignore[reportUnknownMemberType]
         )
 

tests/conftest.py

@@ -9,7 +9,7 @@
 
 def _read_notebook(filename: str) -> nbformat.NotebookNode:
     return cast(
-        nbformat.NotebookNode,
+        "nbformat.NotebookNode",
         nbformat.read(NOTEBOOKS_DIR / filename, as_version=nbformat.NO_CONVERT),  # pyright: ignore[reportUnknownMemberType]
     )
 

tests/test_check_notebook.py

@@ -2,14 +2,15 @@
 
 from typing import TYPE_CHECKING, cast
 
-import nbformat
 import pytest
 
 import nb_clean
 
 if TYPE_CHECKING:
     from collections.abc import Collection
 
+    import nbformat
+
 
 @pytest.mark.parametrize(
     ("notebook_name", "is_clean"),
@@ -22,7 +23,7 @@
 def test_check_notebook(
     notebook_name: str, *, is_clean: bool, request: pytest.FixtureRequest
 ) -> None:
-    notebook = cast(nbformat.NotebookNode, request.getfixturevalue(notebook_name))
+    notebook = cast("nbformat.NotebookNode", request.getfixturevalue(notebook_name))
     assert nb_clean.check_notebook(notebook) is is_clean
 
 
@@ -141,7 +142,7 @@ def test_check_notebook_preserve_outputs(
     is_clean: bool,
     request: pytest.FixtureRequest,
 ) -> None:
-    notebook = cast(nbformat.NotebookNode, request.getfixturevalue(notebook_name))
+    notebook = cast("nbformat.NotebookNode", request.getfixturevalue(notebook_name))
     output = nb_clean.check_notebook(
         notebook, preserve_cell_outputs=preserve_cell_outputs
     )
@@ -162,7 +163,7 @@ def test_check_notebook_preserve_execution_counts(
     is_clean: bool,
     request: pytest.FixtureRequest,
 ) -> None:
-    notebook = cast(nbformat.NotebookNode, request.getfixturevalue(notebook_name))
+    notebook = cast("nbformat.NotebookNode", request.getfixturevalue(notebook_name))
     output = nb_clean.check_notebook(
         notebook, preserve_execution_counts=preserve_execution_counts
     )
@@ -190,7 +191,7 @@ def test_check_notebook_remove_all_notebook_metadata(
     # The test with `("clean_notebook_with_notebook_metadata", False, True)`
     # is False due to `clean_notebook_with_notebook_metadata` containing
     # `language_info.version` detected when `preserve_notebook_metadata=False`.
-    notebook = cast(nbformat.NotebookNode, request.getfixturevalue(notebook_name))
+    notebook = cast("nbformat.NotebookNode", request.getfixturevalue(notebook_name))
     assert (
         nb_clean.check_notebook(
             notebook, remove_all_notebook_metadata=remove_all_notebook_metadata

tests/test_clean_notebook.py

@@ -25,7 +25,7 @@ def test_clean_notebook_with_notebook_metadata(
     request: pytest.FixtureRequest,
 ) -> None:
     expected_output = cast(
-        nbformat.NotebookNode, request.getfixturevalue(expected_output_name)
+        "nbformat.NotebookNode", request.getfixturevalue(expected_output_name)
     )
     assert (
         nb_clean.clean_notebook(

tests/test_cli.py

@@ -156,9 +156,9 @@ def test_check_stdin(
     expect_exit: bool,
     request: pytest.FixtureRequest,
 ) -> None:
-    notebook = cast(nbformat.NotebookNode, request.getfixturevalue(notebook_name))
+    notebook = cast("nbformat.NotebookNode", request.getfixturevalue(notebook_name))
     monkeypatch.setattr(sys, "argv", ["nb-clean", "check"])
-    content = cast(str, nbformat.writes(notebook))  # pyright: ignore[reportUnknownMemberType]
+    content = cast("str", nbformat.writes(notebook))  # pyright: ignore[reportUnknownMemberType]
     monkeypatch.setattr(sys, "stdin", io.StringIO(content))
     if expect_exit:
         with pytest.raises(SystemExit) as exc:
@@ -177,11 +177,11 @@ def test_clean_file(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> None:
     nb_clean.cli.main()
 
     cleaned = cast(
-        nbformat.NotebookNode,
+        "nbformat.NotebookNode",
         nbformat.read(dst_dirty, as_version=nbformat.NO_CONVERT),  # pyright: ignore[reportUnknownMemberType]
     )
     expected = cast(
-        nbformat.NotebookNode,
+        "nbformat.NotebookNode",
         nbformat.read(  # pyright: ignore[reportUnknownMemberType]
             Path("tests/notebooks/clean.ipynb"), as_version=nbformat.NO_CONVERT
         ),
@@ -193,26 +193,26 @@ def test_clean_stdin(
     capsys: CaptureFixture[str], monkeypatch: pytest.MonkeyPatch
 ) -> None:
     dirty = cast(
-        nbformat.NotebookNode,
+        "nbformat.NotebookNode",
         nbformat.read(  # pyright: ignore[reportUnknownMemberType]
             Path("tests/notebooks/dirty.ipynb"), as_version=nbformat.NO_CONVERT
         ),
     )
     expected = cast(
-        nbformat.NotebookNode,
+        "nbformat.NotebookNode",
         nbformat.read(  # pyright: ignore[reportUnknownMemberType]
             Path("tests/notebooks/clean.ipynb"), as_version=nbformat.NO_CONVERT
         ),
     )
 
     monkeypatch.setattr(sys, "argv", ["nb-clean", "clean"])
-    dirty_content = cast(str, nbformat.writes(dirty))  # pyright: ignore[reportUnknownMemberType]
+    dirty_content = cast("str", nbformat.writes(dirty))  # pyright: ignore[reportUnknownMemberType]
     monkeypatch.setattr(sys, "stdin", io.StringIO(dirty_content))
 
     nb_clean.cli.main()
 
     out = capsys.readouterr().out
-    expected_text = cast(str, nbformat.writes(expected))  # pyright: ignore[reportUnknownMemberType]
+    expected_text = cast("str", nbformat.writes(expected))  # pyright: ignore[reportUnknownMemberType]
     assert out.strip() == expected_text.strip()
 
 
@@ -231,7 +231,7 @@ def test_clean_stdin(
         ("add-filter -e", [], True, False, None, False, False, False),
         (
             "check -m -o a.ipynb b.ipynb",
-            "a.ipynb b.ipynb".split(),
+            ["a.ipynb", "b.ipynb"],
             False,
             False,
             [],
@@ -241,7 +241,7 @@ def test_clean_stdin(
         ),
         (
             "check -m tags -o a.ipynb b.ipynb",
-            "a.ipynb b.ipynb".split(),
+            ["a.ipynb", "b.ipynb"],
             False,
             False,
             ["tags"],
@@ -251,7 +251,7 @@ def test_clean_stdin(
         ),
         (
             "check -m tags special -o a.ipynb b.ipynb",
-            "a.ipynb b.ipynb".split(),
+            ["a.ipynb", "b.ipynb"],
             False,
             False,
             ["tags", "special"],