Skip to content

Commit f3c6111

Browse files
Bump curator.version from 5.7.1 to 5.8.0 (#359)
* Bump curator.version from 5.7.1 to 5.8.0 Bumps `curator.version` from 5.7.1 to 5.8.0. Updates `org.apache.curator:curator-framework` from 5.7.1 to 5.8.0 - [Release notes](https://github.com/apache/curator/releases) - [Commits](apache/curator@apache-curator-5.7.1...apache-curator-5.8.0) Updates `org.apache.curator:curator-recipes` from 5.7.1 to 5.8.0 - [Release notes](https://github.com/apache/curator/releases) - [Commits](apache/curator@apache-curator-5.7.1...apache-curator-5.8.0) Updates `org.apache.curator:curator-x-discovery` from 5.7.1 to 5.8.0 - [Release notes](https://github.com/apache/curator/releases) - [Commits](apache/curator@apache-curator-5.7.1...apache-curator-5.8.0) Updates `org.apache.curator:curator-test` from 5.7.1 to 5.8.0 - [Release notes](https://github.com/apache/curator/releases) - [Commits](apache/curator@apache-curator-5.7.1...apache-curator-5.8.0) --- updated-dependencies: - dependency-name: org.apache.curator:curator-framework dependency-version: 5.8.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.curator:curator-recipes dependency-version: 5.8.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.curator:curator-x-discovery dependency-version: 5.8.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.curator:curator-test dependency-version: 5.8.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Fix test * Formatting --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryan Baxter <[email protected]>
1 parent 217a917 commit f3c6111

File tree

2 files changed

+8
-16
lines changed

2 files changed

+8
-16
lines changed

spring-cloud-zookeeper-config/src/test/java/org/springframework/cloud/zookeeper/config/ZookeeperConfigDataCustomizationIntegrationTests.java

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import org.apache.commons.logging.LogFactory;
2323
import org.apache.curator.framework.CuratorFramework;
2424
import org.apache.curator.framework.CuratorFrameworkFactory;
25-
import org.apache.curator.framework.imps.CuratorFrameworkImpl;
2625
import org.junit.After;
2726
import org.junit.Before;
2827
import org.junit.Test;
@@ -51,13 +50,10 @@
5150
*/
5251
public class ZookeeperConfigDataCustomizationIntegrationTests {
5352

54-
private static final Log log = LogFactory
55-
.getLog(ZookeeperConfigDataCustomizationIntegrationTests.class);
56-
5753
public static final String PREFIX = "test__configdata__";
58-
5954
public static final String ROOT = "/" + PREFIX + UUID.randomUUID();
60-
55+
private static final Log log = LogFactory
56+
.getLog(ZookeeperConfigDataCustomizationIntegrationTests.class);
6157
private ConfigurableApplicationContext context;
6258
private BindHandlerBootstrapper bindHandlerBootstrapper;
6359

@@ -86,8 +82,9 @@ CuratorFramework curatorFramework(BootstrapContext context) {
8682
ZookeeperProperties properties = context.get(ZookeeperProperties.class);
8783
CuratorFrameworkFactory.Builder builder = CuratorFrameworkFactory.builder()
8884
.retryPolicy(CuratorFactory.retryPolicy(properties))
89-
.connectString(properties.getConnectString());
90-
TestCuratorFramework curator = new TestCuratorFramework(builder);
85+
.connectString(properties.getConnectString())
86+
.namespace("testnamespace");
87+
CuratorFramework curator = builder.build();
9188
curator.start();
9289
try {
9390
curator.blockUntilConnected(properties.getBlockUntilConnectedWait(),
@@ -102,16 +99,11 @@ CuratorFramework curatorFramework(BootstrapContext context) {
10299
@Test
103100
public void curatorFrameworkIsCustom() {
104101
CuratorFramework curator = context.getBean(CuratorFramework.class);
105-
assertThat(curator).isNotNull().isInstanceOf(TestCuratorFramework.class);
102+
assertThat(curator).isNotNull();
103+
assertThat(curator.getNamespace()).isEqualTo("testnamespace");
106104
assertThat(bindHandlerBootstrapper.onSuccessCount).isGreaterThan(0);
107105
}
108106

109-
static class TestCuratorFramework extends CuratorFrameworkImpl {
110-
TestCuratorFramework(CuratorFrameworkFactory.Builder builder) {
111-
super(builder);
112-
}
113-
}
114-
115107
@Configuration
116108
@EnableAutoConfiguration
117109
static class Config {

spring-cloud-zookeeper-dependencies/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<name>spring-cloud-zookeeper-dependencies</name>
1515
<description>Spring Cloud Zookeeper Dependencies</description>
1616
<properties>
17-
<curator.version>5.7.1</curator.version>
17+
<curator.version>5.8.0</curator.version>
1818
<maven-checkstyle-plugin.failsOnError>true</maven-checkstyle-plugin.failsOnError>
1919
<maven-checkstyle-plugin.failsOnViolation>true</maven-checkstyle-plugin.failsOnViolation>
2020
<maven-checkstyle-plugin.includeTestSourceDirectory>true</maven-checkstyle-plugin.includeTestSourceDirectory>

0 commit comments

Comments
 (0)