Skip to content

Commit 070c0e3

Browse files
hgschmiehazendaz
hgschmie
authored and
hazendaz
committed
Support multiple bug baseline files.
Spotbugs always supported multiple files as a comma-separated list in the <excludeBugsFile> configuration option. This change also adds support for multiple files as a list: <excludeBugsFiles> <excludeBugsFile>...</excludeBugsFile> <excludeBugsFile>...</excludeBugsFile> <excludeBugsFiles> This allows using pom inheritance to control multiple files. As there were no integration tests for the bug baseline files, adds integration tests for - single bug exclusion file - multiple bug exclusion files, comma separated - multiple bug exclusion files as list
1 parent b3e0d8c commit 070c0e3

File tree

13 files changed

+855
-1
lines changed

13 files changed

+855
-1
lines changed

‎src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline-other.xml

Lines changed: 181 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,181 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<BugCollection sequence="0" release="" analysisTimestamp="1653586688929" version="4.7.0" timestamp="1653586685292">
3+
<BugInstance instanceOccurrenceNum="0" instanceHash="c7f9edd192cfef80d2e55dde64a514bc" rank="2" abbrev="INT" category="CORRECTNESS" priority="1" type="INT_BAD_COMPARISON_WITH_SIGNED_BYTE" instanceOccurrenceMax="0">
4+
<ShortMessage>Bad comparison of signed byte</ShortMessage>
5+
<LongMessage>Bad comparison of signed byte with 200 in AssumeUnsignedBytes.find200(byte[])</LongMessage>
6+
<Class classname="AssumeUnsignedBytes" primary="true">
7+
<SourceLine classname="AssumeUnsignedBytes" start="3" end="10" sourcepath="AssumeUnsignedBytes.java" sourcefile="AssumeUnsignedBytes.java">
8+
<Message>At AssumeUnsignedBytes.java:[lines 3-10]</Message>
9+
</SourceLine>
10+
<Message>In class AssumeUnsignedBytes</Message>
11+
</Class>
12+
<Method isStatic="false" classname="AssumeUnsignedBytes" signature="([B)I" name="find200" primary="true">
13+
<SourceLine endBytecode="82" classname="AssumeUnsignedBytes" start="7" end="10" sourcepath="AssumeUnsignedBytes.java" sourcefile="AssumeUnsignedBytes.java" startBytecode="0"/>
14+
<Message>In method AssumeUnsignedBytes.find200(byte[])</Message>
15+
</Method>
16+
<Int role="INT_VALUE" value="200">
17+
<Message>Value 200</Message>
18+
</Int>
19+
<SourceLine endBytecode="14" classname="AssumeUnsignedBytes" start="8" end="8" sourcepath="AssumeUnsignedBytes.java" sourcefile="AssumeUnsignedBytes.java" startBytecode="14" primary="true">
20+
<Message>At AssumeUnsignedBytes.java:[line 8]</Message>
21+
</SourceLine>
22+
</BugInstance>
23+
<BugInstance instanceOccurrenceNum="0" instanceHash="c44f97bf502b32aba37c238aae4e404c" rank="14" abbrev="HE" category="BAD_PRACTICE" priority="1" type="HE_EQUALS_USE_HASHCODE" instanceOccurrenceMax="0">
24+
<ShortMessage>Class defines equals() and uses Object.hashCode()</ShortMessage>
25+
<LongMessage>UseOfNonHashableClassInHashDataStructure defines equals and uses Object.hashCode()</LongMessage>
26+
<Class classname="UseOfNonHashableClassInHashDataStructure" primary="true">
27+
<SourceLine classname="UseOfNonHashableClassInHashDataStructure" start="3" end="24" sourcepath="UseOfNonHashableClassInHashDataStructure.java" sourcefile="UseOfNonHashableClassInHashDataStructure.java">
28+
<Message>At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]</Message>
29+
</SourceLine>
30+
<Message>In class UseOfNonHashableClassInHashDataStructure</Message>
31+
</Class>
32+
<Method isStatic="false" classname="UseOfNonHashableClassInHashDataStructure" signature="(Ljava/lang/Object;)Z" name="equals" primary="true">
33+
<SourceLine endBytecode="51" classname="UseOfNonHashableClassInHashDataStructure" start="16" end="16" sourcepath="UseOfNonHashableClassInHashDataStructure.java" sourcefile="UseOfNonHashableClassInHashDataStructure.java" startBytecode="0"/>
34+
<Message>In method UseOfNonHashableClassInHashDataStructure.equals(Object)</Message>
35+
</Method>
36+
<SourceLine synthetic="true" endBytecode="51" classname="UseOfNonHashableClassInHashDataStructure" start="16" end="16" sourcepath="UseOfNonHashableClassInHashDataStructure.java" sourcefile="UseOfNonHashableClassInHashDataStructure.java" startBytecode="0">
37+
<Message>At UseOfNonHashableClassInHashDataStructure.java:[line 16]</Message>
38+
</SourceLine>
39+
</BugInstance>
40+
<BugInstance instanceOccurrenceNum="0" instanceHash="a4564c101ee03f13b56ee6a6b66efd77" rank="5" abbrev="HE" category="CORRECTNESS" priority="1" type="HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS" instanceOccurrenceMax="0">
41+
<ShortMessage>Signature declares use of unhashable class in hashed construct</ShortMessage>
42+
<LongMessage>UseOfNonHashableClassInHashDataStructure doesn't define a hashCode() method but it is used in a hashed context in UseOfNonHashableClassInHashDataStructure$UMap</LongMessage>
43+
<Class classname="UseOfNonHashableClassInHashDataStructure$UMap" primary="true">
44+
<SourceLine classname="UseOfNonHashableClassInHashDataStructure$UMap" start="5" end="5" sourcepath="UseOfNonHashableClassInHashDataStructure.java" sourcefile="UseOfNonHashableClassInHashDataStructure.java">
45+
<Message>At UseOfNonHashableClassInHashDataStructure.java:[line 5]</Message>
46+
</SourceLine>
47+
<Message>In class UseOfNonHashableClassInHashDataStructure$UMap</Message>
48+
</Class>
49+
<Class classname="UseOfNonHashableClassInHashDataStructure$UMap">
50+
<SourceLine classname="UseOfNonHashableClassInHashDataStructure$UMap" start="5" end="5" sourcepath="UseOfNonHashableClassInHashDataStructure.java" sourcefile="UseOfNonHashableClassInHashDataStructure.java">
51+
<Message>At UseOfNonHashableClassInHashDataStructure.java:[line 5]</Message>
52+
</SourceLine>
53+
<Message>In class UseOfNonHashableClassInHashDataStructure$UMap</Message>
54+
</Class>
55+
<Type role="TYPE_UNHASHABLE" descriptor="LUseOfNonHashableClassInHashDataStructure;">
56+
<SourceLine classname="UseOfNonHashableClassInHashDataStructure" start="3" end="24" sourcepath="UseOfNonHashableClassInHashDataStructure.java" sourcefile="UseOfNonHashableClassInHashDataStructure.java">
57+
<Message>At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]</Message>
58+
</SourceLine>
59+
<Message>Unhashable class UseOfNonHashableClassInHashDataStructure </Message>
60+
</Type>
61+
<SourceLine synthetic="true" classname="UseOfNonHashableClassInHashDataStructure$UMap" start="5" end="5" sourcepath="UseOfNonHashableClassInHashDataStructure.java" sourcefile="UseOfNonHashableClassInHashDataStructure.java">
62+
<Message>At UseOfNonHashableClassInHashDataStructure.java:[line 5]</Message>
63+
</SourceLine>
64+
</BugInstance>
65+
<BugInstance instanceOccurrenceNum="0" instanceHash="e248f9d4626fdfcebf961d28bcbd1d88" cweid="563" rank="5" abbrev="DLS" category="CORRECTNESS" priority="1" type="DLS_OVERWRITTEN_INCREMENT" instanceOccurrenceMax="0">
66+
<ShortMessage>Overwritten increment</ShortMessage>
67+
<LongMessage>Overwritten increment in UselessAssignments.oops()</LongMessage>
68+
<Class classname="UselessAssignments" primary="true">
69+
<SourceLine classname="UselessAssignments" start="14" end="42" sourcepath="UselessAssignments.java" sourcefile="UselessAssignments.java">
70+
<Message>At UselessAssignments.java:[lines 14-42]</Message>
71+
</SourceLine>
72+
<Message>In class UselessAssignments</Message>
73+
</Class>
74+
<Method isStatic="false" classname="UselessAssignments" signature="()I" name="oops" primary="true">
75+
<SourceLine endBytecode="88" classname="UselessAssignments" start="28" end="33" sourcepath="UselessAssignments.java" sourcefile="UselessAssignments.java" startBytecode="0"/>
76+
<Message>In method UselessAssignments.oops()</Message>
77+
</Method>
78+
<SourceLine endBytecode="12" classname="UselessAssignments" start="30" end="30" sourcepath="UselessAssignments.java" sourcefile="UselessAssignments.java" startBytecode="12" primary="true">
79+
<Message>At UselessAssignments.java:[line 30]</Message>
80+
</SourceLine>
81+
</BugInstance>
82+
<BugInstance instanceOccurrenceNum="0" instanceHash="c845f2f6bcbb54ef6993e667f2ab9f6a" rank="1" abbrev="SA" category="CORRECTNESS" priority="1" type="SA_FIELD_SELF_ASSIGNMENT" instanceOccurrenceMax="0">
83+
<ShortMessage>Self assignment of field</ShortMessage>
84+
<LongMessage>Self assignment of field foo in new UselessAssignments(int, int)</LongMessage>
85+
<Class classname="UselessAssignments" primary="true">
86+
<SourceLine classname="UselessAssignments" start="14" end="42" sourcepath="UselessAssignments.java" sourcefile="UselessAssignments.java">
87+
<Message>At UselessAssignments.java:[lines 14-42]</Message>
88+
</SourceLine>
89+
<Message>In class UselessAssignments</Message>
90+
</Class>
91+
<Method isStatic="false" classname="UselessAssignments" signature="(II)V" name="&lt;init&gt;" primary="true">
92+
<SourceLine endBytecode="72" classname="UselessAssignments" start="14" end="20" sourcepath="UselessAssignments.java" sourcefile="UselessAssignments.java" startBytecode="0"/>
93+
<Message>In method new UselessAssignments(int, int)</Message>
94+
</Method>
95+
<Field isStatic="false" classname="UselessAssignments" signature="I" name="foo" primary="true">
96+
<SourceLine classname="UselessAssignments" sourcepath="UselessAssignments.java" sourcefile="UselessAssignments.java">
97+
<Message>In UselessAssignments.java</Message>
98+
</SourceLine>
99+
<Message>Field UselessAssignments.foo</Message>
100+
</Field>
101+
<LocalVariable role="LOCAL_VARIABLE_DID_YOU_MEAN" pc="0" name="?" register="1">
102+
<Message>Did you mean to refer to the local variable ?</Message>
103+
</LocalVariable>
104+
<SourceLine endBytecode="9" classname="UselessAssignments" start="16" end="16" sourcepath="UselessAssignments.java" sourcefile="UselessAssignments.java" startBytecode="9" primary="true">
105+
<Message>At UselessAssignments.java:[line 16]</Message>
106+
</SourceLine>
107+
</BugInstance>
108+
<BugInstance instanceOccurrenceNum="0" instanceHash="48138b3b7d208c1dee75d30c88c3f630" rank="1" abbrev="SA" category="CORRECTNESS" priority="1" type="SA_FIELD_SELF_ASSIGNMENT" instanceOccurrenceMax="0">
109+
<ShortMessage>Self assignment of field</ShortMessage>
110+
<LongMessage>Self assignment of field foo in UselessAssignments.oops()</LongMessage>
111+
<Class classname="UselessAssignments" primary="true">
112+
<SourceLine classname="UselessAssignments" start="14" end="42" sourcepath="UselessAssignments.java" sourcefile="UselessAssignments.java">
113+
<Message>At UselessAssignments.java:[lines 14-42]</Message>
114+
</SourceLine>
115+
<Message>In class UselessAssignments</Message>
116+
</Class>
117+
<Method isStatic="false" classname="UselessAssignments" signature="()I" name="oops" primary="true">
118+
<SourceLine endBytecode="88" classname="UselessAssignments" start="28" end="33" sourcepath="UselessAssignments.java" sourcefile="UselessAssignments.java" startBytecode="0"/>
119+
<Message>In method UselessAssignments.oops()</Message>
120+
</Method>
121+
<Field isStatic="false" classname="UselessAssignments" signature="I" name="foo" primary="true">
122+
<SourceLine classname="UselessAssignments" sourcepath="UselessAssignments.java" sourcefile="UselessAssignments.java">
123+
<Message>In UselessAssignments.java</Message>
124+
</SourceLine>
125+
<Message>Field UselessAssignments.foo</Message>
126+
</Field>
127+
<SourceLine endBytecode="25" classname="UselessAssignments" start="31" end="31" sourcepath="UselessAssignments.java" sourcefile="UselessAssignments.java" startBytecode="25" primary="true">
128+
<Message>At UselessAssignments.java:[line 31]</Message>
129+
</SourceLine>
130+
</BugInstance>
131+
<BugInstance instanceOccurrenceNum="0" instanceHash="ef8d86e8b4ffe32c6b42c02f53d79967" rank="1" abbrev="UR" category="CORRECTNESS" priority="1" type="UR_UNINIT_READ" instanceOccurrenceMax="0">
132+
<ShortMessage>Uninitialized read of field in constructor</ShortMessage>
133+
<LongMessage>Uninitialized read of foo in new UselessAssignments(int, int)</LongMessage>
134+
<Class classname="UselessAssignments" primary="true">
135+
<SourceLine classname="UselessAssignments" start="14" end="42" sourcepath="UselessAssignments.java" sourcefile="UselessAssignments.java">
136+
<Message>At UselessAssignments.java:[lines 14-42]</Message>
137+
</SourceLine>
138+
<Message>In class UselessAssignments</Message>
139+
</Class>
140+
<Method isStatic="false" classname="UselessAssignments" signature="(II)V" name="&lt;init&gt;" primary="true">
141+
<SourceLine endBytecode="72" classname="UselessAssignments" start="14" end="20" sourcepath="UselessAssignments.java" sourcefile="UselessAssignments.java" startBytecode="0"/>
142+
<Message>In method new UselessAssignments(int, int)</Message>
143+
</Method>
144+
<Field isStatic="false" classname="UselessAssignments" signature="I" name="foo" primary="true">
145+
<SourceLine classname="UselessAssignments" sourcepath="UselessAssignments.java" sourcefile="UselessAssignments.java">
146+
<Message>In UselessAssignments.java</Message>
147+
</SourceLine>
148+
<Message>Field UselessAssignments.foo</Message>
149+
</Field>
150+
<LocalVariable role="LOCAL_VARIABLE_DID_YOU_MEAN" pc="0" name="?" register="1">
151+
<Message>Did you mean to refer to the local variable ?</Message>
152+
</LocalVariable>
153+
<SourceLine endBytecode="6" classname="UselessAssignments" start="16" end="16" sourcepath="UselessAssignments.java" sourcefile="UselessAssignments.java" startBytecode="6" primary="true">
154+
<Message>At UselessAssignments.java:[line 16]</Message>
155+
</SourceLine>
156+
</BugInstance>
157+
<BugInstance instanceOccurrenceNum="0" instanceHash="c605add53d7d36f5dea72b09c753696b" rank="19" abbrev="Dm" category="I18N" priority="1" type="DM_DEFAULT_ENCODING" instanceOccurrenceMax="0">
158+
<ShortMessage>Reliance on default encoding</ShortMessage>
159+
<LongMessage>Found reliance on default encoding in UserMistakes.main(String[]): new java.io.FileReader(String)</LongMessage>
160+
<Class classname="UserMistakes" primary="true">
161+
<SourceLine classname="UserMistakes" start="10" end="43" sourcepath="UserMistakes.java" sourcefile="UserMistakes.java">
162+
<Message>At UserMistakes.java:[lines 10-43]</Message>
163+
</SourceLine>
164+
<Message>In class UserMistakes</Message>
165+
</Class>
166+
<Method isStatic="true" classname="UserMistakes" signature="([Ljava/lang/String;)V" name="main" primary="true">
167+
<SourceLine endBytecode="318" classname="UserMistakes" start="13" end="43" sourcepath="UserMistakes.java" sourcefile="UserMistakes.java" startBytecode="0"/>
168+
<Message>In method UserMistakes.main(String[])</Message>
169+
</Method>
170+
<Method isStatic="false" role="METHOD_CALLED" classname="java.io.FileReader" signature="(Ljava/lang/String;)V" name="&lt;init&gt;">
171+
<SourceLine endBytecode="68" classname="java.io.FileReader" start="60" end="61" sourcepath="java/io/FileReader.java" sourcefile="FileReader.java" startBytecode="0"/>
172+
<Message>Called method new java.io.FileReader(String)</Message>
173+
</Method>
174+
<SourceLine endBytecode="57" classname="UserMistakes" start="26" end="26" sourcepath="UserMistakes.java" sourcefile="UserMistakes.java" startBytecode="57" primary="true">
175+
<Message>At UserMistakes.java:[line 26]</Message>
176+
</SourceLine>
177+
<SourceLine role="SOURCE_LINE_ANOTHER_INSTANCE" endBytecode="111" classname="UserMistakes" start="37" end="37" sourcepath="UserMistakes.java" sourcefile="UserMistakes.java" startBytecode="111">
178+
<Message>Another occurrence at UserMistakes.java:[line 37]</Message>
179+
</SourceLine>
180+
</BugInstance>
181+
</BugCollection>

0 commit comments

Comments
 (0)