Skip to content

Commit c7f1bdf

Browse files
committed
Refactor some comments
Signed-off-by: Guilherme Carvalho <[email protected]>
1 parent af12dbe commit c7f1bdf

File tree

2 files changed

+5
-15
lines changed

2 files changed

+5
-15
lines changed

support/oidc-discovery-provider/cert_manager_test.go

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import (
77
"encoding/pem"
88
"fmt"
99
"math/big"
10-
"os"
1110
"reflect"
1211
"strings"
1312
"testing"
@@ -22,15 +21,6 @@ import (
2221

2322
var logger, logHook = test.NewNullLogger()
2423

25-
func TestMain(m *testing.M) {
26-
code := m.Run()
27-
28-
for _, entry := range logHook.AllEntries() {
29-
println(entry.Message)
30-
}
31-
os.Exit(code)
32-
}
33-
3424
func TestTLSConfig(t *testing.T) {
3525
oidcServerKey := testkey.MustEC256()
3626
oidcServerKeyDer, err := x509.MarshalECPrivateKey(oidcServerKey)
@@ -110,7 +100,7 @@ func TestTLSConfig(t *testing.T) {
110100
_, err := NewDiskCertManager(&Config{}, logger)
111101
require.EqualError(t, err, "missing serving cert file configuration")
112102
})
113-
103+
114104
t.Run("error when provided cert path do not exist", func(t *testing.T) {
115105
_, err := NewDiskCertManager(&Config{ServingCertFile: &ServingCertFileConfig{
116106
CertFilePath: tmpDir + "/nonexistent_cert.pem",
@@ -373,7 +363,7 @@ func TestTLSConfig(t *testing.T) {
373363
})
374364

375365
t.Run("change cert and key file permissions will start error log loop", func(t *testing.T) {
376-
// make cert file not readable
366+
// Make cert file not readable
377367
err = makeFileUnreadable(tmpDir + certFilePath)
378368
require.NoError(t, err)
379369

@@ -396,7 +386,7 @@ func TestTLSConfig(t *testing.T) {
396386
Bytes: oidcServerCertUpdated3.Raw,
397387
})
398388

399-
// make cert file readable again
389+
// Make cert file readable again
400390
err = makeFileReadable(tmpDir+certFilePath, oidcServerCertUpdated3Pem)
401391
require.NoError(t, err)
402392

@@ -413,7 +403,7 @@ func TestTLSConfig(t *testing.T) {
413403
return len(errLogs) >= 5
414404
}, 500*time.Millisecond, 10*time.Millisecond, "Failed to assert file permission error logs")
415405

416-
// make cert file readable again
406+
// Make cert file readable again
417407
err = makeFileReadable(tmpDir+keyFilePath, oidcServerKeyPem)
418408
require.NoError(t, err)
419409

support/oidc-discovery-provider/cert_manager_test_windows.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ func makeFileUnreadable(name string) error {
5050
return err
5151
}
5252

53-
// this SDDL code denies generic read access to the owner of the file
53+
// This SDDL code denies generic read access to the owner of the file
5454
sd, err := windows.SecurityDescriptorFromString("D:(D;OICI;GR;;;OW)")
5555
if err != nil {
5656
return err

0 commit comments

Comments
 (0)