Refactor some comments

Signed-off-by: Guilherme Carvalho <[email protected]>

Author: guilhermocc

support/oidc-discovery-provider/cert_manager_test.go

@@ -7,7 +7,6 @@ import (
 	"encoding/pem"
 	"fmt"
 	"math/big"
-	"os"
 	"reflect"
 	"strings"
 	"testing"
@@ -22,15 +21,6 @@ import (
 
 var logger, logHook = test.NewNullLogger()
 
-func TestMain(m *testing.M) {
-	code := m.Run()
-
-	for _, entry := range logHook.AllEntries() {
-		println(entry.Message)
-	}
-	os.Exit(code)
-}
-
 func TestTLSConfig(t *testing.T) {
 	oidcServerKey := testkey.MustEC256()
 	oidcServerKeyDer, err := x509.MarshalECPrivateKey(oidcServerKey)
@@ -110,7 +100,7 @@ func TestTLSConfig(t *testing.T) {
 		_, err := NewDiskCertManager(&Config{}, logger)
 		require.EqualError(t, err, "missing serving cert file configuration")
 	})
-	
+
 	t.Run("error when provided cert path do not exist", func(t *testing.T) {
 		_, err := NewDiskCertManager(&Config{ServingCertFile: &ServingCertFileConfig{
 			CertFilePath: tmpDir + "/nonexistent_cert.pem",
@@ -373,12 +363,11 @@ func TestTLSConfig(t *testing.T) {
 	})
 
 	t.Run("change cert and key file permissions will start error log loop", func(t *testing.T) {
-		//	make cert file not readable
-		err = makeFileUnreadable(tmpDir + certFilePath)
-		require.NoError(t, err)
-
+		// Make cert file not readable
 		err = writeFile(tmpDir+certFilePath, oidcServerCertPem)
 		require.NoError(t, err)
+		err = makeFileUnreadable(tmpDir + certFilePath)
+		require.NoError(t, err)
 
 		// Assert error logs that will keep triggering until the cert permission is valid again.
 		errLogs := map[time.Time]struct{}{}
@@ -396,7 +385,7 @@ func TestTLSConfig(t *testing.T) {
 			Bytes: oidcServerCertUpdated3.Raw,
 		})
 
-		//	make cert file readable again
+		// Make cert file readable again
 		err = makeFileReadable(tmpDir+certFilePath, oidcServerCertUpdated3Pem)
 		require.NoError(t, err)
 
@@ -413,7 +402,7 @@ func TestTLSConfig(t *testing.T) {
 			return len(errLogs) >= 5
 		}, 500*time.Millisecond, 10*time.Millisecond, "Failed to assert file permission error logs")
 
-		//	make cert file readable again
+		// Make cert file readable again
 		err = makeFileReadable(tmpDir+keyFilePath, oidcServerKeyPem)
 		require.NoError(t, err)
 

support/oidc-discovery-provider/cert_manager_test_windows.go

@@ -50,7 +50,7 @@ func makeFileUnreadable(name string) error {
 		return err
 	}
 
-	// this SDDL code denies generic read access to the owner of the file
+	// This SDDL code denies generic read access to the owner of the file
 	sd, err := windows.SecurityDescriptorFromString("D:(D;OICI;GR;;;OW)")
 	if err != nil {
 		return err