Refactor Tests and Improve Effective Revenue Calculation in Weekly Financial Reports

- Reformatted import statements in `fetchFinancialAppData.test.ts` for better readability.
- Adjusted error handling in `fetchFinancialAppData` to ensure proper disconnection of the mongo pool.
- Enhanced test data in `WeeklyFinancialReportRepository.test.ts` to include effective revenue calculations for projects, improving the accuracy of marginality assessments.

These changes enhance the clarity and reliability of financial report tests, ensuring more accurate calculations and better organization of test data.

Author: anatolyshipitz

workers/main/src/activities/weeklyFinancialReports/fetchFinancialAppData.test.ts

@@ -5,7 +5,11 @@ import { AppError } from '../../common/errors';
 import * as fileUtils from '../../common/fileUtils';
 import * as mongoPoolModule from '../../common/MongoPool';
 import type { TargetUnit } from '../../common/types';
-import type { Employee, IFinAppRepository, Project } from '../../services/FinApp';
+import type {
+  Employee,
+  IFinAppRepository,
+  Project,
+} from '../../services/FinApp';
 import * as finAppService from '../../services/FinApp';
 import type { CustomerRevenueByRef } from '../../services/QBO';
 import * as qboService from '../../services/QBO';
@@ -174,7 +178,7 @@ describe('getFinAppData', () => {
 
     it('always disconnects the mongo pool', async () => {
       setupSuccessMocks();
-      await fetchFinancialAppData(fileLink).catch(() => { });
+      await fetchFinancialAppData(fileLink).catch(() => {});
       expect(() => mongoPoolInstance.disconnect()).not.toThrow();
     });
   });

workers/main/src/activities/weeklyFinancialReports/fetchFinancialAppData.ts

@@ -41,7 +41,7 @@ export const fetchFinancialAppData = async (
         ...project,
         effectiveRevenue: project.quick_books_id
           ? effectiveRevenueByCustomerRef[project.quick_books_id]
-            ?.totalAmount || 0
+              ?.totalAmount || 0
           : 0,
       })),
       effectiveRevenue: effectiveRevenueByCustomerRef,

workers/main/src/services/WeeklyFinancialReport/WeeklyFinancialReportRepository.test.ts

@@ -109,9 +109,25 @@ const createMarginalityTestData = () => ({
     { redmine_id: 102, history: { rate: { '2024-01-01': 50 } } },
   ],
   projects: [
-    { redmine_id: 10, history: { rate: { '2024-01-01': 100 } } }, // 50% marginality
-    { redmine_id: 20, history: { rate: { '2024-01-01': 200 } } }, // 75% marginality
-    { redmine_id: 30, history: { rate: { '2024-01-01': 150 } } }, // 67% marginality
+    // 10h @ $50 COGS -> $500 cost. Set effectiveRevenue to achieve target marginality:
+    // 50%: (R - 500) / R = 0.5  => R = 1000
+    {
+      redmine_id: 10,
+      history: { rate: { '2024-01-01': 100 } },
+      effectiveRevenue: 1000,
+    },
+    // 75%: (R - 500) / R = 0.75 => R = 2000
+    {
+      redmine_id: 20,
+      history: { rate: { '2024-01-01': 200 } },
+      effectiveRevenue: 2000,
+    },
+    // ~67%: (1500 - 500) / 1500 ≈ 0.667
+    {
+      redmine_id: 30,
+      history: { rate: { '2024-01-01': 150 } },
+      effectiveRevenue: 1500,
+    },
   ],
 });