Refactor Docker configuration to use environment variables from .env file

- Modified dockerfiles to reduce hardcoded values and use environment variables
- Updated docker-compose.yml to source ports and credentials from environment file
- Enhanced check_services.sh to read from .env instead of using hardcoded values
- Improved README.md with instructions for environment file setup
- Fixed container health checks to use the correct service addresses

Author: killev

Dockerfile.n8n

@@ -1,24 +1,19 @@
 FROM n8nio/n8n:1.89.2
 
 # Define build arguments
-ARG N8N_PORT=5678
 ARG NODE_ENV=production
-
-# Add custom environment variables
-ENV N8N_PORT=${N8N_PORT} \
-    NODE_ENV=${NODE_ENV} \
-    N8N_METRICS=true \
-    N8N_HEALTH_CHECK_ENDPOINT=true
+# Environment variables are now defined in docker-compose.yml
 
 # Create app directory
 WORKDIR /home/node
 
 # Add custom healthcheck using exec form
 HEALTHCHECK --interval=30s --timeout=10s --retries=3 --start-period=30s \
-  CMD ["/bin/sh", "-c", "wget -q --spider http://n8n:${N8N_PORT}/healthz || exit 1"]
+  CMD ["/bin/sh", "-c", "wget -q --spider http://0.0.0.0:${N8N_PORT}/healthz || exit 1"]
 
 # Explicitly set the user to the non-root 'node' user (which is already set up in the base image)
 USER node
 
+EXPOSE ${N8N_PORT}
 # The entrypoint script is already defined in the base image
 # Don't override the CMD 

Dockerfile.temporal

@@ -1,32 +1,20 @@
 FROM temporalio/auto-setup:1.20.5
 
-# Define build arguments with defaults matching the .env file
-ARG POSTGRES_USER=temporal
-ARG POSTGRES_PASSWORD=temporal
-ARG POSTGRES_DB=temporal
-ARG DB_PORT=5432
-ARG POSTGRES_SEEDS=postgresql
-ARG ES_SEEDS=opensearch
-ARG ES_VERSION=v7
+# Build arguments are still needed for the temporal container setup
+# Keeping only those used in the HEALTHCHECK or other commands
+ARG HOST=temporal
+ARG TEMPORAL_PORT=7233
 
-# Set up environment variables for PostgreSQL and OpenSearch
-ENV DB=postgresql \
-    DB_PORT=${DB_PORT} \
-    POSTGRES_USER=${POSTGRES_USER} \
-    POSTGRES_PWD=${POSTGRES_PASSWORD} \
-    POSTGRES_SEEDS=${POSTGRES_SEEDS} \
-    ENABLE_ES=true \
-    ES_SEEDS=${ES_SEEDS} \
-    ES_VERSION=${ES_VERSION}
+# Environment variables are now defined in docker-compose.yml
 
 # Add custom healthcheck using exec form
 HEALTHCHECK --interval=30s --timeout=10s --start-period=30s --retries=3 \
-  CMD ["/bin/sh", "-c", "temporal operator cluster health --address temporal:7233 | grep -q SERVING || exit 1"]
+  CMD ["/bin/sh", "-c", "temporal operator cluster health --address ${HOST}:${TEMPORAL_PORT} | grep -q SERVING || exit 1"]
 
 # Explicitly set the user to the non-root 'temporal' user (already defined in the base image)
 USER temporal
 
 # Expose the gRPC port
-EXPOSE 7233
+EXPOSE ${TEMPORAL_PORT}
 
 # The entrypoint script is already defined in the base image 

README.md

@@ -27,12 +27,21 @@ This project uses custom Docker images built from the following Dockerfiles:
 Before starting the services, run the setup script to create the necessary volume directories:
 
 ```bash
-chmod +x scripts/setup_volumes.sh
 ./scripts/setup_volumes.sh
 ```
 
 This prevents volume mount errors that may occur if the directories don't exist.
 
+### Create environment file
+
+Create a `.env` file in the root directory of the project with your environment variables:
+
+```bash
+cp .env.example .env
+```
+
+Then edit the `.env` file to set your specific configuration values.
+
 ### Starting the services
 
 ```bash

docker-compose.yml

@@ -5,14 +5,18 @@ services:
     build:
       context: .
       dockerfile: Dockerfile.n8n
-      args:
-        - N8N_PORT=5678
     restart: unless-stopped
     ports:
-      - "5678:5678"
+      - "${N8N_PORT}:5678"
     environment:
       - WEBHOOK_URL=${N8N_WEBHOOK_URL}
       - N8N_ENCRYPTION_KEY=${N8N_ENCRYPTION_KEY}
+      - "N8N_RUNNERS_ENABLED=true"
+      - "N8N_ENFORCE_SETTINGS_FILE_PERMISSIONS=true"
+      - "N8N_PORT=5678"
+      - "NODE_ENV=production"
+      - "N8N_METRICS=true"
+      - "N8N_HEALTH_CHECK_ENDPOINT=true"
     volumes:
       - n8n_data:/home/node/.n8n
     networks:
@@ -31,7 +35,7 @@ services:
       - "DISABLE_SECURITY_PLUGIN=${DISABLE_SECURITY_PLUGIN}"
       - "DISABLE_INSTALL_DEMO_CONFIG=true"
     ports:
-      - 9200:9200
+      - ${OPENSEARCH_PORT}:9200
     cap_add:
       - IPC_LOCK
     ulimits:
@@ -43,7 +47,7 @@ services:
     networks:
       - app-network
     healthcheck:
-      test: ["CMD-SHELL", "curl -sSf http://localhost:9200/ || exit 1"]
+      test: ["CMD-SHELL", "curl -sSf http://localhost:${OPENSEARCH_PORT}/ || exit 1"]
       interval: 30s
       timeout: 10s
       retries: 5
@@ -58,7 +62,7 @@ services:
       POSTGRES_PASSWORD: ${POSTGRES_PASSWORD}
       POSTGRES_DB: ${POSTGRES_DB}
     ports:
-      - 5432:5432
+      - ${POSTGRES_PORT}:5432
     volumes:
       - postgresql-data:/var/lib/postgresql/data
     networks:
@@ -77,11 +81,8 @@ services:
       context: .
       dockerfile: Dockerfile.temporal
       args:
-        - POSTGRES_USER=${POSTGRES_USER}
-        - POSTGRES_PASSWORD=${POSTGRES_PASSWORD}
-        - POSTGRES_DB=${POSTGRES_DB}
-        - ES_SEEDS=opensearch
-        - ES_VERSION=v7
+        - HOST=temporal
+        - TEMPORAL_PORT=${TEMPORAL_PORT}
     restart: unless-stopped
     depends_on:
       postgresql:
@@ -91,8 +92,16 @@ services:
     environment:
       - ES_SEEDS=opensearch
       - ES_VERSION=v7
+      - DB=postgresql
+      - DB_PORT=${POSTGRES_PORT}
+      - POSTGRES_USER=${POSTGRES_USER}
+      - POSTGRES_PWD=${POSTGRES_PASSWORD}
+      - POSTGRES_SEEDS=postgresql
+      - ENABLE_ES=true
+      - HOST=temporal
+      - TEMPORAL_PORT=7233
     ports:
-      - 7233:7233
+      - ${TEMPORAL_PORT}:7233
     networks:
       - app-network
     user: temporal
@@ -105,14 +114,14 @@ services:
       temporal:
         condition: service_healthy
     environment:
-      - TEMPORAL_ADDRESS=temporal:7233
+      - TEMPORAL_ADDRESS=temporal:${TEMPORAL_PORT}
       - TEMPORAL_PERMIT_WRITE_API=true
     ports:
-      - 8080:8080
+      - ${TEMPORAL_UI_PORT}:8080
     networks:
       - app-network
     healthcheck:
-      test: ["CMD", "wget", "-O", "/dev/null", "-q", "http://localhost:8080"]
+      test: ["CMD", "wget", "-O", "/dev/null", "-q", "http://temporal-ui:${TEMPORAL_UI_PORT}"]
       interval: 10s
       timeout: 5s
       retries: 5

scripts/check_services.sh

@@ -1,5 +1,13 @@
 #!/bin/bash
 
+# Source environment variables from .env file
+if [ -f .env ]; then
+  source .env
+else
+  echo "Error: .env file not found. Please make sure it exists in the root directory."
+  exit 1
+fi
+
 echo "Checking service availability..."
 
 # Check if docker-compose is running
@@ -23,31 +31,31 @@ check_http_service() {
 }
 
 # Check n8n
-check_http_service "n8n" "http://localhost:5678/healthz"
+check_http_service "n8n" "http://localhost:${N8N_PORT}/healthz"
 
 # Check temporal-ui
-check_http_service "temporal-ui" "http://localhost:8080"
+check_http_service "temporal-ui" "http://localhost:${TEMPORAL_UI_PORT}"
 
 # Check opensearch
-check_http_service "opensearch" "http://localhost:9200"
+check_http_service "opensearch" "http://localhost:${OPENSEARCH_PORT}"
 
 # Check temporal service
-echo -n "Checking temporal at localhost:7233... "
-if nc -z localhost 7233 >/dev/null 2>&1; then
+echo -n "Checking temporal at localhost:${TEMPORAL_PORT}... "
+if nc -z localhost ${TEMPORAL_PORT} >/dev/null 2>&1; then
   echo "ACCESSIBLE ✅"
 else
   echo "NOT ACCESSIBLE ❌"
 fi
 
 # Check PostgreSQL
-echo -n "Checking postgresql at localhost:5432... "
-if docker compose exec postgresql pg_isready -h localhost -p 5432 -U temporal >/dev/null 2>&1; then
+echo -n "Checking postgresql at localhost:${POSTGRES_PORT}... "
+if docker compose exec postgresql pg_isready -h localhost -p ${POSTGRES_PORT} -U ${POSTGRES_USER} >/dev/null 2>&1; then
   echo "ACCESSIBLE ✅"
 else
   echo "NOT ACCESSIBLE ❌"
 fi
 
 echo -e "\nService URLs:"
-echo "- n8n: http://localhost:5678"
-echo "- Temporal UI: http://localhost:8080"
-echo "- OpenSearch: http://localhost:9200" 
+echo "- n8n: http://localhost:${N8N_PORT}"
+echo "- Temporal UI: http://localhost:${TEMPORAL_UI_PORT}"
+echo "- OpenSearch: http://localhost:${OPENSEARCH_PORT}"