Merge pull request #224 from erikn69/patch-1

Nielsvanpach · web-flow · commit 4fd22035e81d · 2024-11-04T09:24:54.000+01:00
PHP 8.4 tests
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -9,7 +9,7 @@ jobs:
             fail-fast: false
             matrix:
                 os: [ubuntu-latest]
-                php: [8.3, 8.2, 8.1, 8.0, 7.4, 7.3]
+                php: [8.4, 8.3, 8.2, 8.1, 8.0, 7.4, 7.3]
                 dependency-version: [prefer-lowest, prefer-stable]
 
         name: P${{ matrix.php }} - ${{ matrix.dependency-version }} - ${{ matrix.os }}
diff --git a/src/OptimizerChain.php b/src/OptimizerChain.php
@@ -62,11 +62,11 @@ public function useLogger(LoggerInterface $log)
         return $this;
     }
 
-    public function optimize(string $pathToImage, string $pathToOutput = null)
+    public function optimize(string $pathToImage, ?string $pathToOutput = null)
     {
         if ($pathToOutput) {
             $check = copy($pathToImage, $pathToOutput);
-            if($check == false) {
+            if ($check == false) {
                 throw new InvalidArgumentException("Cannot copy file");
             }
             $pathToImage = $pathToOutput;

Original file line number	Diff line number	Diff line change
`@@ -62,11 +62,11 @@ public function useLogger(LoggerInterface $log)`
`62`	`62`	`return $this;`
`63`	`63`	`}`
`64`	`64`
`65`		`- public function optimize(string $pathToImage, string $pathToOutput = null)`
	`65`	`+ public function optimize(string $pathToImage, ?string $pathToOutput = null)`
`66`	`66`	`{`
`67`	`67`	`if ($pathToOutput) {`
`68`	`68`	`$check = copy($pathToImage, $pathToOutput);`
`69`		`- if($check == false) {`
	`69`	`+ if ($check == false) {`
`70`	`70`	`throw new InvalidArgumentException("Cannot copy file");`
`71`	`71`	`}`
`72`	`72`	`$pathToImage = $pathToOutput;`