Fix docs

Author: WilliamJamieson

src/roman_datamodels/datamodels/_datamodels.py

@@ -12,7 +12,7 @@
 import functools
 import itertools
 import logging
-from collections.abc import Mapping
+from collections.abc import MutableMapping
 from pathlib import Path
 from typing import TYPE_CHECKING
 
@@ -166,8 +166,8 @@ def __init__(self, init=None, **kwargs):
 
     @classmethod
     def _creator_defaults(
-        cls, defaults: dict[str, Any] | None = None, *, time: Time | None = None
-    ) -> dict[str, dict[str, str | Time]]:
+        cls, defaults: MutableMapping[str, Any] | None = None, *, time: Time | None = None
+    ) -> MutableMapping[str, Any]:
         """
         The default values for the create constructors, `create_minimal` and `create_fake_data`.
 
@@ -185,11 +185,11 @@ def _creator_defaults(
             some values that we want to always set to a specific value.
         """
 
-        def merge_dicts(dict1, dict2):
+        def merge_dicts(dict1: MutableMapping[str, Any], dict2: MutableMapping[str, Any]) -> MutableMapping[str, Any]:
             for key in dict2:
                 if key in dict1:
-                    dict1_is_mapping = isinstance(dict1[key], Mapping)
-                    dict2_is_mapping = isinstance(dict2[key], Mapping)
+                    dict1_is_mapping = isinstance(dict1[key], MutableMapping)
+                    dict2_is_mapping = isinstance(dict2[key], MutableMapping)
 
                     if dict1_is_mapping and dict2_is_mapping:
                         dict1[key] = merge_dicts(dict1[key], dict2[key])
@@ -215,7 +215,7 @@ def merge_dicts(dict1, dict2):
         )
 
     @classmethod
-    def create_minimal(cls, defaults=None):
+    def create_minimal(cls, defaults=None, *, tag=None):
         """
         Class method that constructs an "minimal" model.
 
@@ -240,10 +240,10 @@ def create_minimal(cls, defaults=None):
             be incomplete (invalid) as not all required attributes
             can be guessed.
         """
-        return super().create_minimal(defaults=cls._creator_defaults(defaults))
+        return super().create_minimal(defaults=cls._creator_defaults(defaults), tag=tag)
 
     @classmethod
-    def create_fake_data(cls, defaults=None, shape=None):
+    def create_fake_data(cls, defaults=None, shape=None, *, tag=None):
         """
         Class method that constructs a model filled with fake data.
 
@@ -273,7 +273,9 @@ def create_fake_data(cls, defaults=None, shape=None):
             A valid model with fake data.
         """
         return super().create_fake_data(
-            defaults=cls._creator_defaults(defaults, time=Time("2020-01-01T00:00:00.0", format="isot", scale="utc")), shape=shape
+            defaults=cls._creator_defaults(defaults, time=Time("2020-01-01T00:00:00.0", format="isot", scale="utc")),
+            shape=shape,
+            tag=tag,
         )
 
 

src/roman_datamodels/stnode/_mixins.py

@@ -35,6 +35,8 @@
     "ForcedImageSourceCatalogMixin",
     "ForcedMosaicSourceCatalogMixin",
     "FpsFileDateMixin",
+    "FpsMixin",
+    "GuidewindowMixin",
     "ImageSourceCatalogMixin",
     "L2CalStepMixin",
     "L3CalStepMixin",
@@ -46,6 +48,7 @@
     "SdfSoftwareVersionMixin",
     "TelescopeMixin",
     "TvacFileDateMixin",
+    "TvacMixin",
     "WfiImgPhotomRefMixin",
     "WfiModeMixin",
 ]

src/roman_datamodels/stnode/_tagged.py

@@ -209,9 +209,7 @@ def create_from_node(cls, node, builder=None, *, tag: str | None = None):
     @property
     def _tag(self):
         # _tag is required by asdf to allow __asdf_traverse__
-        if self._read_tag is None:
-            return self._default_tag
-        return self._read_tag
+        return getattr(self, "_read_tag", self._default_tag)
 
     @property
     def tag(self):