feat: createMutable support for class inheritance (#2405)

* feat: createMutable support for class inheritance

* Create tasty-garlics-agree.md

---------

Co-authored-by: Ryan Carniato <[email protected]>

Author: ddomonkos

.changeset/tasty-garlics-agree.md

@@ -0,0 +1,5 @@
+---
+"solid-js": patch
+---
+
+feat: createMutable support for class inheritance

packages/solid/store/src/mutable.ts

@@ -104,9 +104,13 @@ function wrap<T extends StoreNode>(value: T): T {
       !Array.isArray(value) &&
       proto !== Object.prototype;
     if (isClass) {
-      const descriptors = Object.getOwnPropertyDescriptors(proto);
-      keys.push(...Object.keys(descriptors));
-      Object.assign(desc, descriptors);
+      let curProto = proto;
+      while (curProto != null) {
+        const descriptors = Object.getOwnPropertyDescriptors(curProto);
+        keys.push(...Object.keys(descriptors));
+        Object.assign(desc, descriptors);
+        curProto = Object.getPrototypeOf(curProto);
+      }
     }
 
     for (let i = 0, l = keys.length; i < l; i++) {

packages/solid/store/test/mutableWithClass.spec.tsx

@@ -53,4 +53,27 @@ describe("Class Operator test", () => {
     expect(count).toBe(3);
     expect(childCount).toBe(1);
   });
+
+  test("inherited properties", () => {
+    class A {
+      val = 0;
+      get getVal() {
+        return this.val;
+      }
+    }
+    class B extends A {}
+
+    const instance = createMutable(new B());
+    let lastVal: number | undefined;
+
+    createRoot(() => {
+      createEffect(() => {
+        lastVal = instance.getVal;
+      });
+    });
+
+    expect(lastVal).toBe(0);
+    instance.val = 1;
+    expect(lastVal).toBe(1);
+  });
 });