fix: catch synchronous error (#2476)

Author: juanrgm

.changeset/chilled-buttons-hammer.md

@@ -0,0 +1,5 @@
+---
+"solid-js": patch
+---
+
+Catch synchronous errors in `createResource`.

packages/solid/src/reactive/signal.ts

@@ -695,16 +695,24 @@ export function createResource<T, S, R>(
       return;
     }
     if (Transition && pr) Transition.promises.delete(pr);
+    let error: unknown;
     const p =
       initP !== NO_INIT
         ? (initP as T | Promise<T>)
-        : untrack(() =>
-            fetcher(lookup, {
-              value: value(),
-              refetching
-            })
-          );
-    if (!isPromise(p)) {
+        : untrack(() => {
+            try {
+              return fetcher(lookup, {
+                value: value(),
+                refetching
+              });
+            } catch (fetcherError) {
+              error = fetcherError;
+            }
+          });
+    if (error !== undefined) {
+      loadEnd(pr, undefined, castError(error), lookup);
+      return;
+    } else if (!isPromise(p)) {
       loadEnd(pr, p, undefined, lookup);
       return p;
     }

packages/solid/test/resource.spec.ts

@@ -211,6 +211,29 @@ describe("using Resource with errors", () => {
   });
 });
 
+describe("using Resource with synchronous error", () => {
+  let value: Resource<number | undefined>;
+  let error: Error;
+  test("catches the error", async () => {
+    createRoot(() => {
+      catchError(
+        () => {
+          [value] = createResource(() => {
+            throw new Error("Fetcher error");
+          });
+          createRenderEffect(value);
+        },
+        e => {
+          error = e;
+        }
+      );
+    });
+    expect(value.state === "errored").toBe(true);
+    expect(value.error).toBe(error);
+    expect(value.error.message).toBe("Fetcher error");
+  });
+});
+
 describe("using Resource with custom store", () => {
   type User = {
     firstName: string;