make support_email optional

Author: kumailn

packages/cli/src/CliSetup.ts

@@ -52,7 +52,7 @@ function latestReleaseMessage() {
   const messages = [
     `- Banner Graphic image of size 1200x600px is now manadatory for publishing updates.`,
     `- Feature Graphic image of size 1200x1200px is required to be featured in Editor's choice carousel. (optional)`,
-    `- Release metadata must now include publisher.support_email (shown to end users) alongside publisher.email for Solana Mobile outreach.`,
+    `- Release metadata now publishes publisher.support_email when provided; otherwise we reuse publisher.email for end-user support.`,
   ].join('\n\n')
   showMessage(
     `Publishing Tools Version ${ Constants.CLI_VERSION }`,
@@ -97,8 +97,8 @@ createCliCmd.addHelpText(
   "after",
   [
     "",
-    "Release metadata requirements:",
-    "  Ensure publisher.support_email is set in your config. Releases expose this to end users, while publisher.email remains for Solana Mobile outreach.",
+    "Release metadata notes:",
+    "  We include publisher.support_email when provided; if omitted we fall back to publisher.email.",
   ].join("\n")
 );
 
@@ -542,4 +542,4 @@ publishCommand
         }
       });
     }
-  );
+  );

packages/cli/src/__tests__/CliSetupTest.ts

@@ -148,8 +148,8 @@ Commands:
   release [options]  Create a release
   help [command]     display help for command
 
-Release metadata requirements:
-  Ensure publisher.support_email is set in your config. Releases expose this to end users, while publisher.email remains for Solana Mobile outreach.
+Release metadata notes:
+  We include publisher.support_email when provided; if omitted we fall back to publisher.email.
 `;
 
   const createAppHelp = `Usage: dapp-store create app [options]
@@ -180,4 +180,4 @@ Options:
   -h, --help                                           display help for command
 `;
 
-});
+});

packages/cli/src/config/PublishDetails.ts

@@ -74,10 +74,6 @@ export const loadPublishDetailsWithChecks = async (
 ): Promise<PublishDetails> => {
   const config = await loadPublishDetails(Constants.getConfigFilePath());
 
-  if (!config.publisher?.support_email?.length) {
-    throw new Error("Please specify `publisher.support_email` in your configuration file. This email is displayed to dApp Store users for end-user support.");
-  }
-
   // We validate that the config is going to have at least one installable asset
   const apkEntry = config.release.files.find(
     (asset: PublishDetails["release"]["files"][0]) => asset.purpose === "install"

packages/cli/src/prebuild_schema/publishing_source.yaml

@@ -2,7 +2,7 @@ publisher:
   name: <<[REQUIRED] YOUR_PUBLISHER_NAME>>
   website: <<[REQUIRED] URL_OF_PUBLISHER_WEBSITE>>
   email: <<[REQUIRED] EMAIL_ADDRESS_TO_CONTACT_PUBLISHER>>
-  support_email: <<[REQUIRED] SUPPORT_EMAIL_ADDRESS_FOR_END_USERS>>
+  support_email: <<[Optional] SUPPORT_EMAIL_ADDRESS_FOR_END_USERS>>
 app:
   name: <<[REQUIRED] APP_NAME>>
   address: ""
@@ -61,4 +61,4 @@ solana_mobile_dapp_publisher_portal:
     - address: <<Optional. genesis token wallet address>>
       comment: <<Optional. For internal use only>>
     - address: <<Optional. genesis token wallet address>>
-      comment: <<Optional. For internal use only>>
+      comment: <<Optional. For internal use only>>

packages/cli/src/prebuild_schema/schemagen.js

@@ -18,7 +18,7 @@ try {
 
   schema["properties"]
     ["publisher"]
-    .required = ["name", "website", "email", "support_email"];
+    .required = ["name", "website", "email"];
 
   // Generator adds some keys/values we don't need & mess up validation
   delete schema.$schema;

packages/core/src/create/ReleaseCore.ts

@@ -130,7 +130,7 @@ export const createReleaseJson = async (
           name: publisherDetails.name,
           website: publisherDetails.website,
           contact: publisherDetails.email,
-          support_email: publisherDetails.support_email,
+          support_email: publisherDetails.support_email ?? publisherDetails.email,
         },
         release_details: {
           updated_on: new Date().toISOString(),

packages/core/src/types.ts

@@ -43,7 +43,7 @@ export type Publisher = {
   name: string;
   website: string;
   email: string;
-  support_email: string;
+  support_email?: string;
 };
 
 export type App = {

publishing-spec/SPEC.md

@@ -161,7 +161,7 @@ The following is a readable example instance with sample data filled in:
 }
 ```
 
-The `publisher_details` block includes both a `contact` address used by Solana Mobile to reach the publisher team directly and a `support_email` that is surfaced to end users in the dApp Store.
+The `publisher_details` block includes both a `contact` address used by Solana Mobile to reach the publisher team directly and a `support_email` that is surfaced to end users in the dApp Store. If `support_email` is omitted when we fallback to `contact`.
 
 ## App NFT JSON