fix(iOS, SplitView): Update showSecondaryToggleButton dynamically #3047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0maboro
force-pushed
the
@t0maboro/secondary-only-button-updates
branch
from
272ff38 to
412104a
Compare
t0maboro
force-pushed
the
@t0maboro/secondary-only-button-updates
branch
from
412104a to
61d9ce9
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an option to update
showSecondaryToggleButtonprop dynamically. As for now, it requires some layout update to trigger refresh of the navbar to which this button is attached. After some investigation, we found that we can forcefully update that navbar by hiding it and opening again. With an assumption that it's done in a single transaction, no flicker/lag is observed.Closes https://github.com/software-mansion/react-native-screens-labs/issues/285 .
Changes
Screenshots / GIFs
Simulator.Screen.Recording.-.iPad.Pro.13-inch.M4.-.2025-07-21.at.13.05.11.mp4
Test code and steps to reproduce
Updated SplitViewBaseApp
Checklist