-
-
Notifications
You must be signed in to change notification settings - Fork 600
chore(iOS, SplitView): Add internal documentation for SplitView #3042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4e1bd31 to
5e32591
Compare
76a574a to
99a1ea7
Compare
5e32591 to
d379dfb
Compare
99a1ea7 to
ce015cf
Compare
d379dfb to
4480f53
Compare
ce015cf to
ab051cf
Compare
89927b5 to
7b36ee5
Compare
ab051cf to
8611f0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't read every single comment, just took a quick look & added some remarks.
General remark is that it is not necessary to have a doc comment for every single method / property, especially in cases where the comment does not give any additional context about method semantics / behaviour above repeating return value type & prop name.
My suggestion would be to comment only where there are some internal invariants or behaviours / interactions that are not contained directly in the prop / method name.
This is in large part a matter of taste, therefore I won't contest this that hard.
Below I added some remarks to indicate what I consider useful and what not, just to maybe give you some guidance.
| /** | ||
| * @brief Enables presentation/dismissal of hidden column using swipe gesture. | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E.g. this doc comment is useful & nice that we have it as it brings some additional context not directly inferable from the prop type & name.
8611f0d to
e75b9c0
Compare
Description
This PR covers current SplitView APIs with a documentation in Doxygen format.
Closes: https://github.com/software-mansion/react-native-screens-labs/issues/289
Changes
Test code and steps to reproduce
No functional changes
Checklist