Skip to content

Conversation

@t0maboro
Copy link
Contributor

@t0maboro t0maboro commented Jul 21, 2025

Description

This PR covers current SplitView APIs with a documentation in Doxygen format.

Closes: https://github.com/software-mansion/react-native-screens-labs/issues/289

Changes

  • Covered all native SplitView classes with documentation

Test code and steps to reproduce

No functional changes

Checklist

  • Included code example that can be used to test this change
  • Ensured that CI passes

@t0maboro t0maboro self-assigned this Jul 21, 2025
@t0maboro t0maboro requested a review from kmichalikk July 21, 2025 09:56
@t0maboro t0maboro force-pushed the @t0maboro/split-view-documentation branch from 4e1bd31 to 5e32591 Compare July 21, 2025 11:18
@t0maboro t0maboro force-pushed the @t0maboro/split-view-internal-docs branch from 76a574a to 99a1ea7 Compare July 21, 2025 11:20
@t0maboro t0maboro force-pushed the @t0maboro/split-view-documentation branch from 5e32591 to d379dfb Compare July 21, 2025 16:35
@t0maboro t0maboro force-pushed the @t0maboro/split-view-internal-docs branch from 99a1ea7 to ce015cf Compare July 21, 2025 16:37
@t0maboro t0maboro force-pushed the @t0maboro/split-view-documentation branch from d379dfb to 4480f53 Compare July 21, 2025 18:55
@t0maboro t0maboro force-pushed the @t0maboro/split-view-internal-docs branch from ce015cf to ab051cf Compare July 21, 2025 18:56
@t0maboro t0maboro force-pushed the @t0maboro/split-view-documentation branch from 89927b5 to 7b36ee5 Compare July 22, 2025 17:03
@t0maboro t0maboro force-pushed the @t0maboro/split-view-internal-docs branch from ab051cf to 8611f0d Compare July 22, 2025 17:23
@t0maboro t0maboro changed the base branch from @t0maboro/split-view-documentation to main July 22, 2025 17:23
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't read every single comment, just took a quick look & added some remarks.

General remark is that it is not necessary to have a doc comment for every single method / property, especially in cases where the comment does not give any additional context about method semantics / behaviour above repeating return value type & prop name.

My suggestion would be to comment only where there are some internal invariants or behaviours / interactions that are not contained directly in the prop / method name.

This is in large part a matter of taste, therefore I won't contest this that hard.

Below I added some remarks to indicate what I consider useful and what not, just to maybe give you some guidance.

Comment on lines 59 to 61
/**
* @brief Enables presentation/dismissal of hidden column using swipe gesture.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E.g. this doc comment is useful & nice that we have it as it brings some additional context not directly inferable from the prop type & name.

@t0maboro t0maboro force-pushed the @t0maboro/split-view-internal-docs branch from 8611f0d to e75b9c0 Compare July 23, 2025 10:52
@t0maboro t0maboro merged commit f4e03d8 into main Jul 23, 2025
4 checks passed
@t0maboro t0maboro deleted the @t0maboro/split-view-internal-docs branch July 23, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants