fix(Android): going back on fabric with horizontal list crash #2403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoLewicki
reviewed
Oct 14, 2024
kkafar
reviewed
Oct 14, 2024
Member
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Just a single note, the logic seems ok.
11 tasks
kkafar
pushed a commit
that referenced
this pull request
Oct 25, 2024
## Description This PR handles yet another case for going back on fabric. In the previous one (#2383) I omitted a case where a horizontal list is simply rendered w/o being nested in any other list! Fixes #2341 ## Changes - updated `Test2292.tsx` repro - handle `parentView is ReactHorizontalScrollView` <!-- ## Screenshots / GIFs Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Test code and steps to reproduce - use `Test2282.tsx` repro ## Checklist - [x] Included code example that can be used to test this change - [x] Ensured that CI passes (cherry picked from commit d40e108)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR handles yet another case for going back on fabric. In the previous one (#2383) I omitted a case where a horizontal list is simply rendered w/o being nested in any other list!
Fixes #2341
Changes
Test2292.tsxreproparentView is ReactHorizontalScrollViewTest code and steps to reproduce
Test2282.tsxreproChecklist