Skip to content

Commit dd242eb

Browse files
committed
fix(Android): add missing setters in view manager interfaces for legacy arch (#220)
## Description #193, #192 were merged before #217 & #217 did not include all necessary changes. ## Changes Updated interfaces / delegates after #193 & #192 added new props. ## Test code and steps to reproduce `Example` should build just fine on Android ## Checklist - [ ] Ensured that CI passes
1 parent 1edf757 commit dd242eb

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

android/src/paper/java/com/facebook/react/viewmanagers/RNSBottomTabsManagerDelegate.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,12 @@ public void setProperty(T view, String propName, @Nullable Object value) {
5757
case "tabBarItemBadgeBackgroundColor":
5858
mViewManager.setTabBarItemBadgeBackgroundColor(view, ColorPropConverter.getColor(value, view.getContext()));
5959
break;
60+
case "tabBarItemTitleFontColorActive":
61+
mViewManager.setTabBarItemTitleFontColorActive(view, ColorPropConverter.getColor(value, view.getContext()));
62+
break;
63+
case "tabBarItemIconColorActive":
64+
mViewManager.setTabBarItemIconColorActive(view, ColorPropConverter.getColor(value, view.getContext()));
65+
break;
6066
case "controlNavigationStateInJS":
6167
mViewManager.setControlNavigationStateInJS(view, value == null ? false : (boolean) value);
6268
break;

android/src/paper/java/com/facebook/react/viewmanagers/RNSBottomTabsManagerInterface.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,7 @@ public interface RNSBottomTabsManagerInterface<T extends View> {
2626
void setTabBarItemTitlePositionAdjustment(T view, @Nullable ReadableMap value);
2727
void setTabBarItemIconColor(T view, @Nullable Integer value);
2828
void setTabBarItemBadgeBackgroundColor(T view, @Nullable Integer value);
29+
void setTabBarItemTitleFontColorActive(T view, @Nullable Integer value);
30+
void setTabBarItemIconColorActive(T view, @Nullable Integer value);
2931
void setControlNavigationStateInJS(T view, boolean value);
3032
}

0 commit comments

Comments
 (0)