Skip to content

Commit a089eeb

Browse files
authored
Rename SlicingClassifier -> SliceAwareClassifier (#1453)
* Rename SlicingClassifier -> SliceAwareClassifier * Rename test
1 parent d6e79d1 commit a089eeb

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

docs/packages/slicing.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ Programmatic data set slicing: SF creation, monitoring utilities, and representa
1414
apply.dask.PandasParallelSFApplier
1515
PandasSFApplier
1616
SFApplier
17+
SliceAwareClassifier
1718
SliceCombinerModule
18-
SlicingClassifier
1919
SlicingFunction
2020
apply.spark.SparkSFApplier
2121
add_slice_labels

snorkel/slicing/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,5 @@
44
from .modules.slice_combiner import SliceCombinerModule # noqa: F401
55
from .monitor import slice_dataframe # noqa: F401
66
from .sf.core import SlicingFunction, slicing_function # noqa: F401
7-
from .slicing_classifier import SlicingClassifier # noqa: F401
7+
from .sliceaware_classifier import SliceAwareClassifier # noqa: F401
88
from .utils import add_slice_labels, convert_to_slice_tasks # noqa: F401

snorkel/slicing/slicing_classifier.py renamed to snorkel/slicing/sliceaware_classifier.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
from .utils import add_slice_labels, convert_to_slice_tasks
1414

1515

16-
class SlicingClassifier(MultitaskClassifier):
16+
class SliceAwareClassifier(MultitaskClassifier):
1717
"""A slice-aware classifier that supports training + scoring on slice labels.
1818
1919
NOTE: This model currently only supports binary classification.
@@ -87,7 +87,7 @@ def __init__(
8787
slice_tasks = convert_to_slice_tasks(self.base_task, slice_names)
8888

8989
# Initialize a MultitaskClassifier with all slice_tasks
90-
model_name = f"{task_name}_slicing_classifier"
90+
model_name = f"{task_name}_sliceaware_classifier"
9191
super().__init__(tasks=slice_tasks, name=model_name, **multitask_kwargs)
9292
self.slice_names = slice_names
9393

test/slicing/test_slicing_classifier.py renamed to test/slicing/test_sliceaware_classifier.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
from snorkel.analysis import Scorer
88
from snorkel.classification import DictDataset
9-
from snorkel.slicing import SFApplier, SlicingClassifier, slicing_function
9+
from snorkel.slicing import SFApplier, SliceAwareClassifier, slicing_function
1010

1111

1212
@slicing_function()
@@ -63,7 +63,7 @@ def setUp(self):
6363
for split in splits
6464
]
6565

66-
self.slice_model = SlicingClassifier(
66+
self.slice_model = SliceAwareClassifier(
6767
base_architecture=self.mlp,
6868
head_dim=self.hidden_dim,
6969
slice_names=[sf.name for sf in sfs],

0 commit comments

Comments
 (0)