Comments

Author: mxiao-cll

packages/sources/por-address-list/src/transport/addressManager.ts

@@ -51,26 +51,39 @@ export abstract class AddressManager<T> {
   abstract processPoRAddressList(result: T[], network: string, chainId: string): PoRAddress[]
 }
 
-export class DefaultAddressManager extends AddressManager<string[]> {
+type DefaultAddressManagerResponseType = string[]
+export class DefaultAddressManager extends AddressManager<DefaultAddressManagerResponseType> {
   getPoRAddressListCall(start: ethers.BigNumber, end: number, blockTag: number) {
     return this.contract.getPoRAddressList(start, end, { blockTag })
   }
 
-  processPoRAddressList(result: string[][], network: string, chainId: string) {
-    return result.flat().map((address) => ({
-      address,
-      network,
-      chainId,
-    }))
+  processPoRAddressList(
+    result: DefaultAddressManagerResponseType[],
+    network: string,
+    chainId: string,
+  ) {
+    return result
+      .flat()
+      .map((address) => ({
+        address,
+        network,
+        chainId,
+      }))
+      .sort()
   }
 }
 
-export class LombardAddressManager extends AddressManager<string[][]> {
+type LombardAddressManagerResponseType = string[][]
+export class LombardAddressManager extends AddressManager<LombardAddressManagerResponseType> {
   getPoRAddressListCall(start: ethers.BigNumber, end: number, blockTag: number) {
     return this.contract.getPoRAddressSignatureMessages(start.toNumber(), end, { blockTag })
   }
 
-  processPoRAddressList(result: string[][][], network: string, chainId: string) {
+  processPoRAddressList(
+    result: LombardAddressManagerResponseType[],
+    network: string,
+    chainId: string,
+  ) {
     return result
       .flatMap((r) => r[0])
       .filter((address) => address != '')
@@ -79,5 +92,6 @@ export class LombardAddressManager extends AddressManager<string[][]> {
         network: network,
         chainId: chainId,
       }))
+      .sort()
   }
 }