Allow null for process timeout

Fixes #476

Author: dmlloyd

process/src/main/java/io/smallrye/common/process/ProcessBuilderImpl.java

@@ -177,13 +177,13 @@ public ProcessBuilder<O> exitCodeChecker(final IntPredicate checker) {
 
     public ProcessBuilder<O> softExitTimeout(final Duration duration) {
         check();
-        this.softExitTimeout = Assert.checkNotNullParam("duration", duration);
+        this.softExitTimeout = duration;
         return this;
     }
 
     public ProcessBuilder<O> hardExitTimeout(final Duration duration) {
         check();
-        this.hardExitTimeout = Assert.checkNotNullParam("duration", duration);
+        this.hardExitTimeout = duration;
         return this;
     }
 

process/src/test/java/io/smallrye/common/process/ProcessUtilTest.java

@@ -1,9 +1,9 @@
 package io.smallrye.common.process;
 
-import org.junit.jupiter.api.Test;
-
 import static org.junit.jupiter.api.Assertions.assertFalse;
 
+import org.junit.jupiter.api.Test;
+
 public class ProcessUtilTest {
 
     @Test

process/src/test/java/io/smallrye/common/process/TestBasicExecution.java

@@ -9,18 +9,23 @@
 import java.net.URISyntaxException;
 import java.net.URL;
 import java.nio.file.Path;
+import java.time.Duration;
+import java.time.temporal.ChronoUnit;
 import java.util.ArrayDeque;
 import java.util.List;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.ExecutionException;
 import java.util.stream.Stream;
 
+import org.junit.jupiter.api.Assumptions;
 import org.junit.jupiter.api.Test;
 
+import io.smallrye.common.os.OS;
 import io.smallrye.common.process.helpers.Cat;
 import io.smallrye.common.process.helpers.Cwd;
 import io.smallrye.common.process.helpers.Errorifier;
 import io.smallrye.common.process.helpers.ErrorifierWithOutput;
+import io.smallrye.common.process.helpers.WaitForever;
 
 public class TestBasicExecution {
 
@@ -244,6 +249,30 @@ public void testNullPointerOnRedirect() throws Exception {
         });
     }
 
+    @Test
+    public void testSoftTimeout() throws Exception {
+        // windows doesn't do soft timeouts
+        Assumptions.assumeFalse(OS.WINDOWS.isCurrent());
+        assertThrows(AbnormalExitException.class, () -> {
+            ProcessBuilder.newBuilder(ProcessUtil.pathOfJava())
+                    .arguments(findHelper(WaitForever.class))
+                    .softExitTimeout(Duration.of(50, ChronoUnit.MILLIS))
+                    .hardExitTimeout(null)
+                    .run();
+        });
+    }
+
+    @Test
+    public void testHardTimeout() throws Exception {
+        assertThrows(AbnormalExitException.class, () -> {
+            ProcessBuilder.newBuilder(ProcessUtil.pathOfJava())
+                    .arguments(findHelper(WaitForever.class))
+                    .softExitTimeout(null)
+                    .hardExitTimeout(Duration.of(50, ChronoUnit.MILLIS))
+                    .run();
+        });
+    }
+
     @Test
     public void testFormatInfiniteLoop() {
         // just make sure it doesn't infinitely loop

process/src/test/java/io/smallrye/common/process/helpers/WaitForever.java

@@ -0,0 +1,13 @@
+package io.smallrye.common.process.helpers;
+
+import java.util.concurrent.locks.LockSupport;
+
+public final class WaitForever {
+    public static void main(String[] args) {
+        System.out.close();
+        System.err.close();
+        for (;;) {
+            LockSupport.park();
+        }
+    }
+}