add more optimistic get() before computeIfAbsent() calls

Author: Ladicek

core/src/main/java/org/jboss/jandex/AnnotationOverlayImpl.java

@@ -243,6 +243,11 @@ public final Collection<AnnotationInstance> annotations(Declaration declaration)
 
     Collection<AnnotationInstance> getAnnotationsFor(Declaration declaration) {
         EquivalenceKey key = EquivalenceKey.of(declaration);
+        // optimistic `get` to avoid `computeIfAbsent` for most calls
+        Collection<AnnotationInstance> result = overlay.get(key);
+        if (result != null) {
+            return result;
+        }
         return overlay.computeIfAbsent(key, new Function<EquivalenceKey, Collection<AnnotationInstance>>() {
             @Override
             public Collection<AnnotationInstance> apply(EquivalenceKey ignored) {

core/src/main/java/org/jboss/jandex/DotName.java

@@ -354,12 +354,11 @@ public String apply(DotName name) {
     public String toString(char delim) {
         if (componentized) {
             if (delim == '.' && startsWithJava()) {
-                // optimistic get to avoid computeIfAbsent for most calls
+                // optimistic `get` to avoid `computeIfAbsent` for most calls
                 String name = JAVA_STRINGS.get(this);
                 if (name != null) {
                     return name;
                 }
-
                 return JAVA_STRINGS.computeIfAbsent(this, COMPONENTIZED_TO_STRING);
             }
             StringBuilder builder = new StringBuilder(stringLength());

core/src/main/java/org/jboss/jandex/EquivalenceKey.java

@@ -519,12 +519,11 @@ public ClassTypeEquivalenceKey apply(DotName name) {
 
         private static ClassTypeEquivalenceKey of(DotName name) {
             if (name.startsWithJava()) {
-                // optimistic get to avoid computeIfAbsent for most calls
+                // optimistic `get` to avoid `computeIfAbsent` for most calls
                 ClassTypeEquivalenceKey equivalenceKey = JAVA_INSTANCES.get(name);
                 if (equivalenceKey != null) {
                     return equivalenceKey;
                 }
-
                 return JAVA_INSTANCES.computeIfAbsent(name, FACTORY);
             }
             return new ClassTypeEquivalenceKey(name);

core/src/main/java/org/jboss/jandex/MethodSignatureKey.java

@@ -65,6 +65,11 @@ public MethodSignatureKey apply(MethodInfo method) {
 
     static MethodSignatureKey of(MethodInfo method) {
         if (method.declaringClass().name().startsWithJava()) {
+            // optimistic `get` to avoid `computeIfAbsent` for most calls
+            MethodSignatureKey key = JAVA_METHOD_SIGNATURES.get(method);
+            if (key != null) {
+                return key;
+            }
             return JAVA_METHOD_SIGNATURES.computeIfAbsent(method, CREATE_METHOD_SIGNATURE);
         }
         return CREATE_METHOD_SIGNATURE.apply(method);

core/src/main/java/org/jboss/jandex/MutableAnnotationOverlayImpl.java

@@ -18,6 +18,11 @@ final class MutableAnnotationOverlayImpl extends AnnotationOverlayImpl implement
     @Override
     Collection<AnnotationInstance> getAnnotationsFor(Declaration declaration) {
         EquivalenceKey key = EquivalenceKey.of(declaration);
+        // optimistic `get` to avoid `computeIfAbsent` for most calls
+        Collection<AnnotationInstance> result = overlay.get(key);
+        if (result != null) {
+            return result;
+        }
         return overlay.computeIfAbsent(key, new Function<EquivalenceKey, Collection<AnnotationInstance>>() {
             @Override
             public Collection<AnnotationInstance> apply(EquivalenceKey ignored) {

gizmo2/src/main/java/org/jboss/jandex/gizmo2/Jandex2Gizmo.java

@@ -59,12 +59,11 @@ public class Jandex2Gizmo {
      * @param name the Jandex {@code DotName} (must not be {@code null})
      */
     public static ClassDesc classDescOf(DotName name) {
-        // optimistic get to avoid computeIfAbsent for most calls
+        // optimistic `get` to avoid `computeIfAbsent` for most calls
         ClassDesc classDesc = CLASS_DESC_CACHE.get(name);
         if (classDesc != null) {
             return classDesc;
         }
-
         return CLASS_DESC_CACHE.computeIfAbsent(name, nameParam -> {
             if (nameParam.prefix() == null) {
                 String local = nameParam.local();