Skip to content

Commit c2bbd82

Browse files
committed
Drop node 12
And embrace Node 18 See https://nodejs.org/en/about/releases/
1 parent 18d5601 commit c2bbd82

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ jobs:
143143

144144
strategy:
145145
matrix:
146-
node-version: [12, 14, 16]
146+
node-version: [14, 16, 18]
147147

148148
steps:
149149
- uses: actions/checkout@v2

lib/sinon/default-behaviors.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -269,6 +269,7 @@ var defaultBehaviors = {
269269
Object.defineProperty(rootStub.rootObj, rootStub.propName, {
270270
value: newVal,
271271
enumerable: true,
272+
writable: true,
272273
configurable:
273274
rootStub.shadowsPropOnPrototype ||
274275
isPropertyConfigurable(rootStub.rootObj, rootStub.propName),

0 commit comments

Comments
 (0)