Fix timings.end being undefined when stream is destroyed before completion

Fixes #2282

Author: sindresorhus

source/core/index.ts

@@ -545,6 +545,20 @@ export default class Request extends Duplex implements RequestEvents<Request> {
 			this._request.destroy();
 		}
 
+		// Workaround: http-timer only sets timings.end when the response emits 'end'.
+		// When a stream is destroyed before completion, the 'end' event may not fire,
+		// leaving timings.end undefined. This should ideally be fixed in http-timer
+		// by listening to the 'close' event, but we handle it here for now.
+		// Only set timings.end if there was no error or abort (to maintain semantic correctness).
+		const timings = (this._request as ClientRequestWithTimings)?.timings;
+		if (timings && is.undefined(timings.end) && !is.undefined(timings.response) && is.undefined(timings.error) && is.undefined(timings.abort)) {
+			timings.end = Date.now();
+			if (is.undefined(timings.phases.total)) {
+				timings.phases.download = timings.end - timings.response;
+				timings.phases.total = timings.end - timings.start;
+			}
+		}
+
 		if (error !== null && !is.undefined(error) && !(error instanceof RequestError)) {
 			error = new RequestError(error.message, error, this);
 		}

test/timings.ts

@@ -54,3 +54,34 @@ test('http/2 timings', withHttpsServer(), async (t, server, got) => {
 	t.true(phases.download! >= 0);
 	t.true(phases.total! >= 0);
 });
+
+test('timings.end is set when stream is destroyed before completion', withServer, async (t, server, got) => {
+	server.get('/', (_request, response) => {
+		response.write('chunk1');
+		// Don't end the response, so it stays open
+	});
+
+	await new Promise<void>((resolve, reject) => {
+		const stream = got.stream('');
+
+		stream.on('data', () => {
+			stream.destroy(new Error('Manual destroy'));
+		});
+
+		stream.on('error', (error: Error) => {
+			t.is(error.message, 'Manual destroy');
+			t.truthy(stream.timings);
+			t.truthy(stream.timings!.response);
+			t.truthy(stream.timings!.end);
+			t.true(stream.timings!.end! >= stream.timings!.response!);
+			t.truthy(stream.timings!.phases.total);
+			resolve();
+		});
+
+		stream.on('end', () => {
+			reject(new Error('Stream should not end normally'));
+		});
+	});
+
+	t.pass();
+});