explicit-length-check: Ignore this.{size,length} (#1289)

Author: fisker

rules/explicit-length-check.js

@@ -151,15 +151,18 @@ function create(context) {
 
 	return {
 		[lengthSelector](lengthNode) {
-			let node;
-			let autoFix = true;
+			if (lengthNode.object.type === 'ThisExpression') {
+				return;
+			}
 
 			const staticValue = getStaticValue(lengthNode, context.getScope());
 			if (staticValue && (!Number.isInteger(staticValue.value) || staticValue.value < 0)) {
 				// Ignore known, non-positive-integer length properties.
 				return;
 			}
 
+			let node;
+			let autoFix = true;
 			let {isZeroLengthCheck, node: lengthCheckNode} = getLengthCheckNode(lengthNode);
 			if (lengthCheckNode) {
 				const {isNegative, node: ancestor} = getBooleanAncestor(lengthCheckNode);

test/explicit-length-check.mjs

@@ -138,7 +138,17 @@ test({
 });
 
 test.snapshot({
-	valid: [],
+	valid: [
+		// Ignored
+		outdent`
+			class A {
+				a() {
+					if (this.length);
+					while (!this.size || foo);
+				}
+			}
+		`
+	],
 	invalid: [
 		outdent`
 			if (