prefer-prototype-methods: Fix a missing condition on object literal check (#1332)

Author: fisker

rules/prefer-prototype-methods.js

@@ -84,6 +84,7 @@ function create(context) {
 				if (
 					functionNode &&
 					functionNode.parent.type === 'Property' &&
+					functionNode.parent.value === functionNode &&
 					functionNode.parent.parent.type === 'ObjectExpression'
 				) {
 					return;

test/prefer-prototype-methods.mjs

@@ -85,6 +85,11 @@ test.snapshot({
 				}
 			}
 		`,
+		outdent`
+			const foo = {
+				[function() {this.method.bind(this);}]: 1
+			}
+		`,
 		outdent`
 			const {foo} = {foo: {}};
 			const bar = foo.method.call(foo, 'property');

test/snapshots/prefer-prototype-methods.mjs.md

@@ -263,6 +263,20 @@ Generated by [AVA](https://avajs.dev).
     `
 
 ## Invalid #2
+      1 | const foo = {
+      2 | 	[function() {this.method.bind(this);}]: 1
+      3 | }
+
+> Error 1/1
+
+    `␊
+      1 | const foo = {␊
+    > 2 | 	[function() {this.method.bind(this);}]: 1␊
+        | 	             ^^^^^^^^^^^ Prefer using \`method\` method from the constructor prototype.␊
+      3 | }␊
+    `
+
+## Invalid #3
       1 | const {foo} = {foo: {}};
       2 | const bar = foo.method.call(foo, 'property');
 
@@ -274,7 +288,7 @@ Generated by [AVA](https://avajs.dev).
         |             ^^^^^^^^^^ Prefer using \`method\` method from the constructor prototype.␊
     `
 
-## Invalid #3
+## Invalid #4
       1 | const [foo] = [{}];
       2 | const bar = foo.method.call(foo, 'property');
 
@@ -286,7 +300,7 @@ Generated by [AVA](https://avajs.dev).
         |             ^^^^^^^^^^ Prefer using \`method\` method from the constructor prototype.␊
     `
 
-## Invalid #4
+## Invalid #5
       1 | const foo = {
       2 | 	a() {
       3 | 		this.propertyIsEnumerable.apply(this, []);
@@ -304,7 +318,7 @@ Generated by [AVA](https://avajs.dev).
       5 | }␊
     `
 
-## Invalid #5
+## Invalid #6
       1 | const foo = {
       2 | 	a() {
       3 | 		function fn() {
@@ -330,7 +344,7 @@ Generated by [AVA](https://avajs.dev).
       9 | }␊
     `
 
-## Invalid #6
+## Invalid #7
       1 | this.method = this.method.bind(this)
 
 > Error 1/1
@@ -340,7 +354,7 @@ Generated by [AVA](https://avajs.dev).
         |               ^^^^^^^^^^^ Prefer using \`method\` method from the constructor prototype.␊
     `
 
-## Invalid #7
+## Invalid #8
       1 | const foo = {};
       2 | const bar = foo.hasOwnProperty.call(foo, 'property');
 
@@ -352,7 +366,7 @@ Generated by [AVA](https://avajs.dev).
         |             ^^^^^^^^^^^^^^^^^^ Prefer using \`hasOwnProperty\` method from the constructor prototype.␊
     `
 
-## Invalid #8
+## Invalid #9
       1 | for (const foo of []) foo.bar.call(foo)
 
 > Error 1/1
@@ -362,7 +376,7 @@ Generated by [AVA](https://avajs.dev).
         |                       ^^^^^^^ Prefer using \`bar\` method from the constructor prototype.␊
     `
 
-## Invalid #9
+## Invalid #10
       1 | let foo = {};
       2 | const bar = foo.method.call(foo, 'property');
 
@@ -374,7 +388,7 @@ Generated by [AVA](https://avajs.dev).
         |             ^^^^^^^^^^ Prefer using \`method\` method from the constructor prototype.␊
     `
 
-## Invalid #10
+## Invalid #11
       1 | ({method() {}}).propertyIsEnumerable.call(foo)
 
 > Error 1/1