no-array-reduce: Report optional chaining and calling of .reduce() (#2721)

Co-authored-by: fisker <[email protected]>

Author: ipanasenko

rules/no-array-reduce.js

@@ -17,7 +17,6 @@ const cases = [
 				minimumArguments: 1,
 				maximumArguments: 2,
 				optionalCall: false,
-				optionalMember: false,
 			})
 			&& !isNodeValueNotFunction(callExpression.arguments[0]),
 		getMethodNode: callExpression => callExpression.callee.property,

test/no-array-reduce.js

@@ -12,6 +12,8 @@ test({
 		'a[b.reduce]()',
 		'a(b.reduce)',
 		'a.reduce()',
+		'a?.reduce()',
+		'a.reduce?.()',
 		'a.reduce(1, 2, 3)',
 		'a.reduce(b, c, d)',
 		'[][reduce].call()',
@@ -79,6 +81,9 @@ test({
 		// More or less argument(s)
 		// We are not checking arguments length
 
+		// Ignore optional call to avoid false positive on non-array objects
+		'array.reduce?.((str, item) => str += item, "")',
+
 		// `reduce-like`
 		'array.reducex(foo)',
 		'array.xreduce(foo)',
@@ -106,6 +111,7 @@ test({
 	].flatMap(testCase => [testCase, testCase.replace('reduce', 'reduceRight')]),
 	invalid: [
 		'array.reduce((str, item) => str += item, "")',
+		'array?.reduce((str, item) => str += item, "")',
 		outdent`
 			array.reduce((obj, item) => {
 				obj[item] = null;