Add support for custom errors in the throw-new-error rule (#88)

Author: liubinyi

rules/throw-new-error.js

@@ -1,21 +1,13 @@
 'use strict';
 
-const errorTypes = [
-	'Error',
-	'EvalError',
-	'RangeError',
-	'ReferenceError',
-	'SyntaxError',
-	'TypeError',
-	'URIError'
-];
+const customError = /^(?:[A-Z][a-z0-9]*)*Error$/;
 
 const create = context => ({
 	ThrowStatement: node => {
 		const arg = node.argument;
 		const error = arg.callee;
 
-		if (arg.type === 'CallExpression' && errorTypes.indexOf(error.name) !== -1) {
+		if (arg.type === 'CallExpression' && customError.test(error.name)) {
 			context.report({
 				node,
 				message: 'Use `new` when throwing an error.',

test/throw-new-error.js

@@ -14,7 +14,15 @@ ruleTester.run('new-error', rule, {
 	valid: [
 		'throw new Error()',
 		'new Error()',
-		'throw new TypeError()'
+		'throw new TypeError()',
+		'throw new EvalError()',
+		'throw new RangeError()',
+		'throw new ReferenceError()',
+		'throw new SyntaxError()',
+		'throw new URIError()',
+		'throw new CustomError()',
+		'throw new FooBarBazError()',
+		'throw new ABCError()'
 	],
 	invalid: [
 		{
@@ -27,10 +35,55 @@ ruleTester.run('new-error', rule, {
 			output: `throw new Error('foo')`,
 			errors
 		},
+		{
+			code: `throw CustomError('foo')`,
+			output: `throw new CustomError('foo')`,
+			errors
+		},
+		{
+			code: `throw FooBarBazError('foo')`,
+			output: `throw new FooBarBazError('foo')`,
+			errors
+		},
+		{
+			code: `throw ABCError('foo')`,
+			output: `throw new ABCError('foo')`,
+			errors
+		},
+		{
+			code: `throw Abc3Error('foo')`,
+			output: `throw new Abc3Error('foo')`,
+			errors
+		},
 		{
 			code: `throw TypeError()`,
 			output: 'throw new TypeError()',
 			errors
+		},
+		{
+			code: `throw EvalError()`,
+			output: 'throw new EvalError()',
+			errors
+		},
+		{
+			code: `throw RangeError()`,
+			output: 'throw new RangeError()',
+			errors
+		},
+		{
+			code: `throw ReferenceError()`,
+			output: 'throw new ReferenceError()',
+			errors
+		},
+		{
+			code: `throw SyntaxError()`,
+			output: 'throw new SyntaxError()',
+			errors
+		},
+		{
+			code: `throw URIError()`,
+			output: 'throw new URIError()',
+			errors
 		}
 	]
 });