Skip to content

Commit 4ca42ae

Browse files
committed
Rename as prefer-single-call
1 parent 339051d commit 4ca42ae

File tree

9 files changed

+10
-10
lines changed

9 files changed

+10
-10
lines changed

docs/deleted-and-deprecated-rules.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Replaced by [`no-instanceof-builtins`](rules/no-instanceof-builtins.md) which co
88

99
### no-array-push-push
1010

11-
Replaced by [`prefer-combinable-action`](rules/prefer-combinable-action.md) which covers more cases.
11+
Replaced by [`prefer-single-call`](rules/prefer-single-call.md) which covers more cases.
1212

1313
### no-length-as-slice-end
1414

docs/rules/prefer-combinable-action.md renamed to docs/rules/prefer-single-call.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ Example:
5555

5656
```js
5757
{
58-
'unicorn/prefer-combinable-action': [
58+
'unicorn/prefer-single-call': [
5959
'error',
6060
{
6161
ignore: [
@@ -68,7 +68,7 @@ Example:
6868
```
6969

7070
```js
71-
// eslint unicorn/prefer-combinable-action: ["error", {"ignore": ["readable"]}]
71+
// eslint unicorn/prefer-single-call: ["error", {"ignore": ["readable"]}]
7272
import {Readable} from 'node:stream';
7373

7474
const readable = new Readable();

index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ const deprecatedRules = createDeprecatedRules({
1414
replacedBy: ['unicorn/no-unnecessary-slice-end'],
1515
},
1616
'no-array-push-push': {
17-
message: 'Replaced by `unicorn/prefer-combinable-action` which covers more cases.',
18-
replacedBy: ['unicorn/prefer-combinable-action'],
17+
message: 'Replaced by `unicorn/prefer-single-call` which covers more cases.',
18+
replacedBy: ['unicorn/prefer-single-call'],
1919
},
2020
});
2121

readme.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,6 @@ export default [
133133
| [prefer-at](docs/rules/prefer-at.md) | Prefer `.at()` method for index access and `String#charAt()`. || 🔧 | 💡 |
134134
| [prefer-blob-reading-methods](docs/rules/prefer-blob-reading-methods.md) | Prefer `Blob#arrayBuffer()` over `FileReader#readAsArrayBuffer(…)` and `Blob#text()` over `FileReader#readAsText(…)`. || | |
135135
| [prefer-code-point](docs/rules/prefer-code-point.md) | Prefer `String#codePointAt(…)` over `String#charCodeAt(…)` and `String.fromCodePoint(…)` over `String.fromCharCode(…)`. || | 💡 |
136-
| [prefer-combinable-action](docs/rules/prefer-combinable-action.md) | Enforce combining multiple `Array#push()`, `Element#classList.{add,remove}()`, and `importScripts()` into one call. || 🔧 | 💡 |
137136
| [prefer-date-now](docs/rules/prefer-date-now.md) | Prefer `Date.now()` to get the number of milliseconds since the Unix Epoch. || 🔧 | |
138137
| [prefer-default-parameters](docs/rules/prefer-default-parameters.md) | Prefer default parameters over reassignment. || 🔧 | 💡 |
139138
| [prefer-dom-node-append](docs/rules/prefer-dom-node-append.md) | Prefer `Node#append()` over `Node#appendChild()`. || 🔧 | |
@@ -165,6 +164,7 @@ export default [
165164
| [prefer-regexp-test](docs/rules/prefer-regexp-test.md) | Prefer `RegExp#test()` over `String#match()` and `RegExp#exec()`. || 🔧 | 💡 |
166165
| [prefer-set-has](docs/rules/prefer-set-has.md) | Prefer `Set#has()` over `Array#includes()` when checking for existence or non-existence. || 🔧 | 💡 |
167166
| [prefer-set-size](docs/rules/prefer-set-size.md) | Prefer using `Set#size` instead of `Array#length`. || 🔧 | |
167+
| [prefer-single-call](docs/rules/prefer-single-call.md) | Enforce combining multiple `Array#push()`, `Element#classList.{add,remove}()`, and `importScripts()` into one call. || 🔧 | 💡 |
168168
| [prefer-spread](docs/rules/prefer-spread.md) | Prefer the spread operator over `Array.from(…)`, `Array#concat(…)`, `Array#{slice,toSpliced}()` and `String#split('')`. || 🔧 | 💡 |
169169
| [prefer-string-raw](docs/rules/prefer-string-raw.md) | Prefer using the `String.raw` tag to avoid escaping `\`. || 🔧 | |
170170
| [prefer-string-replace-all](docs/rules/prefer-string-replace-all.md) | Prefer `String#replaceAll()` over regex searches with the global flag. || 🔧 | |

rules/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ import preferArraySome from './prefer-array-some.js';
7878
import preferAt from './prefer-at.js';
7979
import preferBlobReadingMethods from './prefer-blob-reading-methods.js';
8080
import preferCodePoint from './prefer-code-point.js';
81-
import preferCombinableAction from './prefer-combinable-action.js';
8281
import preferDateNow from './prefer-date-now.js';
8382
import preferDefaultParameters from './prefer-default-parameters.js';
8483
import preferDomNodeAppend from './prefer-dom-node-append.js';
@@ -110,6 +109,7 @@ import preferReflectApply from './prefer-reflect-apply.js';
110109
import preferRegexpTest from './prefer-regexp-test.js';
111110
import preferSetHas from './prefer-set-has.js';
112111
import preferSetSize from './prefer-set-size.js';
112+
import preferSingleCall from './prefer-single-call.js';
113113
import preferSpread from './prefer-spread.js';
114114
import preferStringRaw from './prefer-string-raw.js';
115115
import preferStringReplaceAll from './prefer-string-replace-all.js';
@@ -210,7 +210,6 @@ const rules = {
210210
'prefer-at': createRule(preferAt, 'prefer-at'),
211211
'prefer-blob-reading-methods': createRule(preferBlobReadingMethods, 'prefer-blob-reading-methods'),
212212
'prefer-code-point': createRule(preferCodePoint, 'prefer-code-point'),
213-
'prefer-combinable-action': createRule(preferCombinableAction, 'prefer-combinable-action'),
214213
'prefer-date-now': createRule(preferDateNow, 'prefer-date-now'),
215214
'prefer-default-parameters': createRule(preferDefaultParameters, 'prefer-default-parameters'),
216215
'prefer-dom-node-append': createRule(preferDomNodeAppend, 'prefer-dom-node-append'),
@@ -242,6 +241,7 @@ const rules = {
242241
'prefer-regexp-test': createRule(preferRegexpTest, 'prefer-regexp-test'),
243242
'prefer-set-has': createRule(preferSetHas, 'prefer-set-has'),
244243
'prefer-set-size': createRule(preferSetSize, 'prefer-set-size'),
244+
'prefer-single-call': createRule(preferSingleCall, 'prefer-single-call'),
245245
'prefer-spread': createRule(preferSpread, 'prefer-spread'),
246246
'prefer-string-raw': createRule(preferStringRaw, 'prefer-string-raw'),
247247
'prefer-string-replace-all': createRule(preferStringReplaceAll, 'prefer-string-replace-all'),
File renamed without changes.
File renamed without changes.

test/snapshots/prefer-combinable-action.js.md renamed to test/snapshots/prefer-single-call.js.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
# Snapshot report for `test/prefer-combinable-action.js`
1+
# Snapshot report for `test/prefer-single-call.js`
22

3-
The actual snapshot is saved in `prefer-combinable-action.js.snap`.
3+
The actual snapshot is saved in `prefer-single-call.js.snap`.
44

55
Generated by [AVA](https://avajs.dev).
66

0 commit comments

Comments
 (0)