prefer-node-protocol: Handle TypeScript import types (#2774)

Co-authored-by: fisker Cheung <[email protected]>

Author: sadan4

docs/rules/prefer-node-protocol.md

@@ -50,3 +50,11 @@ const fs = process.getBuiltinModule('fs/promises');
 // ✅
 const fs = process.getBuiltinModule('node:fs/promises');
 ```
+
+```ts
+// ❌
+type Fs = import('fs');
+
+// ✅
+type Fs = import('node:fs');
+```

rules/prefer-node-protocol.js

@@ -10,6 +10,9 @@ const messages = {
 };
 const NODE_PROTOCOL = 'node:';
 
+/**
+@param {import('eslint').Rule.RuleContext} context
+*/
 const create = context => ({
 	Literal(node) {
 		if (!(
@@ -34,6 +37,12 @@ const create = context => ({
 				)
 				&& node.parent.arguments[0] === node
 			)
+			|| (
+				node.parent.type === 'TSLiteralType'
+				&& node.parent.literal === node
+				&& node.parent.parent.type === 'TSImportType'
+				&& node.parent.parent.argument === node.parent
+			)
 		)) {
 			return;
 		}

test/prefer-node-protocol.js

@@ -132,3 +132,34 @@ test.babel({
 		},
 	],
 });
+
+test.typescript({
+	valid: [
+		'const fs = require("node:fs") as "fs";',
+		'type fs = typeof import("node:fs");',
+		'type fs = typeof SomeType<"fs">;',
+		'type fs = typeof fs;',
+	],
+	invalid: [
+		{
+			code: 'const fs = require("fs") as typeof import("fs");',
+			output: 'const fs = require("node:fs") as typeof import("node:fs");',
+			errors: 2,
+		},
+		{
+			code: 'type fs = import("fs");',
+			output: 'type fs = import("node:fs");',
+			errors: 1,
+		},
+		{
+			code: 'type fs = import("fs").fs<"fs">',
+			output: 'type fs = import("node:fs").fs<"fs">',
+			errors: 1,
+		},
+		{
+			code: 'const fs = someFunc() as SomeType<typeof import("fs")>;',
+			output: 'const fs = someFunc() as SomeType<typeof import("node:fs")>;',
+			errors: 1,
+		},
+	],
+});