prefer-node-protocol: Support process.getBuiltinModule() (#2611)

Author: fisker

docs/rules/prefer-node-protocol.md

@@ -7,40 +7,46 @@
 <!-- end auto-generated rule header -->
 <!-- Do not manually modify this header. Run: `npm run fix:eslint-docs` -->
 
-When importing builtin modules, it's better to use the [`node:` protocol](https://nodejs.org/api/esm.html#node-imports) as it makes it perfectly clear that the package is a Node.js builtin module.
+When getting builtin modules, it's better to use the [`node:` protocol](https://nodejs.org/api/esm.html#node-imports) as it makes it perfectly clear that the package is a Node.js builtin module.
 
-## Fail
+## Examples
 
 ```js
+// ❌
 import dgram from 'dgram';
+
+// ✅
+import dgram from 'node:dgram';
 ```
 
 ```js
+// ❌
 export {strict as default} from 'assert';
+
+// ✅
+export {strict as default} from 'node:assert';
 ```
 
 ```js
+// ❌
 import fs from 'fs/promises';
-```
-
-## Pass
 
-```js
-import dgram from 'node:dgram';
+// ✅
+import fs from 'node:fs/promises';
 ```
 
 ```js
-export {strict as default} from 'node:assert';
-```
+// ❌
+const fs = require('fs/promises');
 
-```js
-import fs from 'node:fs/promises';
+// ✅
+const fs = require('node:fs/promises');
 ```
 
 ```js
-import _ from 'lodash';
-```
+// ❌
+const fs = process.getBuiltinModule('fs/promises');
 
-```js
-import fs from './fs.js';
+// ✅
+const fs = process.getBuiltinModule('node:fs/promises');
 ```

rules/prefer-node-protocol.js

@@ -1,5 +1,8 @@
 import isBuiltinModule from 'is-builtin-module';
-import isStaticRequire from './ast/is-static-require.js';
+import {
+	isStaticRequire,
+	isMethodCall,
+} from './ast/index.js';
 
 const MESSAGE_ID = 'prefer-node-protocol';
 const messages = {
@@ -19,7 +22,16 @@ const create = context => ({
 				&& node.parent.source === node
 			)
 			|| (
-				isStaticRequire(node.parent)
+				(
+					isMethodCall(node.parent, {
+						object: 'process',
+						method: 'getBuiltinModule',
+						argumentsLength: 1,
+						optionalCall: false,
+						optionalMember: false,
+					})
+					|| isStaticRequire(node.parent)
+				)
 				&& node.parent.arguments[0] === node
 			)
 		)) {

test/prefer-node-protocol.js

@@ -92,6 +92,29 @@ test.snapshot({
 	],
 });
 
+// `process.getBuiltinModule`
+test.snapshot({
+	valid: [
+		'const fs = process.getBuiltinModule("node:fs")',
+		'const fs = process.getBuiltinModule?.("fs")',
+		'const fs = process?.getBuiltinModule("fs")',
+		'const fs = process.notGetBuiltinModule("fs")',
+		'const fs = notProcess.getBuiltinModule("fs")',
+		'const fs = process.getBuiltinModule("fs", extra)',
+		'const fs = process.getBuiltinModule(...["fs"])',
+		'const fs = process.getBuiltinModule()',
+		'const fs = process.getBuiltinModule("unicorn")',
+		// Not checking this to avoid false positive
+		outdent`
+			import {getBuiltinModule} from 'node:process';
+			const fs = getBuiltinModule("fs");
+		`,
+	],
+	invalid: [
+		'const fs = process.getBuiltinModule("fs")',
+	],
+});
+
 test.babel({
 	valid: [
 		'export fs from "node:fs";',

test/snapshots/prefer-node-protocol.js.md

@@ -363,3 +363,24 @@ Generated by [AVA](https://avajs.dev).
     > 1 | const fs = require('fs/promises')␊
         |                    ^^^^^^^^^^^^^ Prefer \`node:fs/promises\` over \`fs/promises\`.␊
     `
+
+## invalid(1): const fs = process.getBuiltinModule("fs")
+
+> Input
+
+    `␊
+      1 | const fs = process.getBuiltinModule("fs")␊
+    `
+
+> Output
+
+    `␊
+      1 | const fs = process.getBuiltinModule("node:fs")␊
+    `
+
+> Error 1/1
+
+    `␊
+    > 1 | const fs = process.getBuiltinModule("fs")␊
+        |                                     ^^^^ Prefer \`node:fs\` over \`fs\`.␊
+    `