Update dependency rubocop to '~> 1.80.0' (#311)

* Update dependency rubocop to '~> 1.80.0'
* Cleanup for rubocop
* Bump version

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Steven Pritchard <[email protected]>

Author: renovate[bot]

CHANGELOG

@@ -1,3 +1,6 @@
+* Mon Sep 22 2025 Steven Pritchard <[email protected]> - 4.14.2
+- Clean up for latest rubocop
+
 * Wed Sep 17 2025 Steven Pritchard <[email protected]> - 4.14.1
 - Update dependencies
 

Gemfile

@@ -13,7 +13,7 @@ gem_sources.each { |gem_source| source gem_source }
 group :syntax do
   gem 'metadata-json-lint'
   gem 'puppet-lint-trailing_comma-check', require: false
-  gem 'rubocop', '~> 1.69.2'
+  gem 'rubocop', '~> 1.80.0'
   gem 'rubocop-performance', '~> 1.23.0'
   gem 'rubocop-rake', '~> 0.6.0'
   gem 'rubocop-rspec', '~> 3.3.0'

lib/facter/simp_puppet_settings.rb

@@ -38,7 +38,7 @@
             value = values.interpolate(setting_name)
             Facter.debug "#{section.to_s.ljust(12, '.')}" \
                          "#{setting_name.to_s.ljust(32)} = #{value.to_s.ljust(20)}" \
-                         "#{setting.deprecated? ? ' *** DEPRECATED ***' : ''}"
+                         "#{' *** DEPRECATED ***' if setting.deprecated?}"
             next if setting.deprecated?
             retval[section.to_s][setting_name.to_s] = value.to_s
           end

lib/facter/simplib__auditd.rb

@@ -61,7 +61,7 @@
       status['enforcing'] = procs.any? { |x| x =~ %r{\sauditd\Z} }
     else
       cmdline = Facter.value('cmdline') || {}
-      status['kernel_enforcing'] = ((cmdline['audit']).to_s == '1')
+      status['kernel_enforcing'] = (cmdline['audit'].to_s == '1')
     end
 
     status

lib/facter/simplib__mountpoints.rb

@@ -114,7 +114,7 @@
           else
             [opt_arr[0], opt_arr[1]]
           end
-        end
+        end,
       ]
       # rubocop:enable Style/MultilineBlockChain
 

lib/puppet/functions/simplib/module_exist.rb

@@ -9,7 +9,7 @@
     required_param 'String[1]', :module_name
   end
 
-  def module_exist(module_name)
+  def module_exist(module_name) # rubocop:disable Naming/PredicateMethod
     author, name = module_name.split(%r{/|-})
 
     unless name

lib/puppet/functions/simplib/passgen/simpkv/valid_password_info.rb

@@ -14,7 +14,7 @@
     required_param 'Hash', :password_info
   end
 
-  def valid_password_info(password_info)
+  def valid_password_info(password_info) # rubocop:disable Naming/PredicateMethod
     password_info['value'].key?('password') &&
       password_info['value'].key?('salt') &&
       password_info.key?('metadata') &&

lib/puppet/functions/simplib/validate_deep_hash.rb

@@ -90,7 +90,7 @@ def validate_deep_hash(reference, to_check)
     raise(err_msg)
   end
 
-  def valid_value(value)
+  def valid_value(value) # rubocop:disable Naming/PredicateMethod
     [String, TrueClass, FalseClass, Numeric, NilClass].each do |allowed_class|
       return true if value.is_a?(allowed_class)
     end

lib/puppet/provider/init_ulimit/systemd.rb

@@ -16,13 +16,13 @@ def exists?
     true
   end
 
-  def create
+  def create # rubocop:disable Naming/PredicateMethod
     # Stub, never called
     debug('init_ulimit: If you got here, something very bad happened!')
     true
   end
 
-  def destroy
+  def destroy # rubocop:disable Naming/PredicateMethod
     warning('init_ulimit: ulimits cannot be removed when targeting systemd artifacts')
     true
   end

lib/puppet/type/prepend_file_line.rb

@@ -29,7 +29,7 @@
   newparam(:path) do
     desc 'File to possibly prepend a line to.'
     validate do |value|
-      unless (Puppet.features.posix? && value =~ (%r{^/})) || (Puppet.features.microsoft_windows? && (value =~ (%r{^.:/}) || value =~ (%r{^//[^/]+/[^/]+})))
+      unless (Puppet.features.posix? && value =~ %r{^/}) || (Puppet.features.microsoft_windows? && (value =~ %r{^.:/} || value =~ %r{^//[^/]+/[^/]+}))
         raise(Puppet::Error, "File paths must be fully qualified, not '#{value}'")
       end
     end