fix: autoCancel respected when hook is unmounted

Author: Lukas Kral

src/index.js

@@ -251,7 +251,11 @@ export function makeUseAxios(configureOptions) {
         request(withCancelToken(config), options, dispatch).catch(() => {})
       }
 
-      return cancelOutstandingRequest
+      return () => {
+        if (options.autoCancel) {
+          cancelOutstandingRequest()
+        }
+      }
     }, [config, options, withCancelToken, cancelOutstandingRequest])
 
     const refetch = React.useCallback(

test/index.test.jsx

@@ -387,6 +387,20 @@ function standardTests(
         expect(cancel).not.toHaveBeenCalled()
       })
 
+      it('should skip default cancellation after unmount if options.autoCancel is set to false', async () => {
+        axios.mockResolvedValue({ data: 'whatever' })
+
+        const { waitForNextUpdate, unmount } = setup('', {
+          autoCancel: false
+        })
+
+        await waitForNextUpdate()
+
+        unmount()
+
+        expect(cancel).not.toHaveBeenCalled()
+      })
+
       it('should provide the cancel token to axios', async () => {
         axios.mockResolvedValueOnce({ data: 'whatever' })