Skip to content

Conversation

@woodruffw
Copy link
Member

This enables debugging in our self-tests, and ensures that we print out the Python and pip versions while debugging.

@woodruffw woodruffw requested review from tetsuo-cpp and tnytown May 1, 2023 15:22
@woodruffw woodruffw self-assigned this May 1, 2023
Copy link
Contributor

@tnytown tnytown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but do we want to use the builtin GitHub action debug switch over our bespoke internal-be-careful-debug variable? https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/enabling-debug-logging

@woodruffw
Copy link
Member Author

This looks good, but do we want to use the builtin GitHub action debug switch over our bespoke internal-be-careful-debug variable? https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/enabling-debug-logging

Yeah, we should do that. Let's merge this in and open an issue for refactoring everything to use the built-in debugging variable/::debug feature.

Copy link
Contributor

@tetsuo-cpp tetsuo-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice addition.

@tetsuo-cpp tetsuo-cpp merged commit d48c9cd into main Aug 8, 2023
@tetsuo-cpp tetsuo-cpp deleted the ww/more-debug branch August 8, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants