Skip to content

Commit c973bfc

Browse files
committed
Reduce log severity for late and unrevealed blocks (#3775)
## Issue Addressed NA ## Proposed Changes In #3725 I introduced a `CRIT` log for unrevealed payloads, against @michaelsproul's [advice](#3725 (comment)). After being woken up in the middle of the night by a block that was not revealed to the BN but *was* revealed to the network, I have capitulated. This PR implements @michaelsproul's suggestion and reduces the severity to `ERRO`. Additionally, I have dropped a `CRIT` to an `ERRO` for when a block is published late. The block in question was indeed published late on the network, however now that we have builders that can slow down block production I don't think the error is "actionable" enough to warrant a `CRIT` for the user. ## Additional Info NA
1 parent 979b73c commit c973bfc

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

beacon_node/execution_layer/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1556,7 +1556,7 @@ impl<T: EthSpec> ExecutionLayer<T> {
15561556
&metrics::EXECUTION_LAYER_BUILDER_REVEAL_PAYLOAD_OUTCOME,
15571557
&[metrics::FAILURE],
15581558
);
1559-
crit!(
1559+
error!(
15601560
self.log(),
15611561
"Builder failed to reveal payload";
15621562
"info" => "this relay failure may cause a missed proposal",

beacon_node/http_api/src/publish_blocks.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ use beacon_chain::{
55
};
66
use lighthouse_network::PubsubMessage;
77
use network::NetworkMessage;
8-
use slog::{crit, error, info, warn, Logger};
8+
use slog::{error, info, warn, Logger};
99
use slot_clock::SlotClock;
1010
use std::sync::Arc;
1111
use tokio::sync::mpsc::UnboundedSender;
@@ -72,18 +72,18 @@ pub async fn publish_block<T: BeaconChainTypes>(
7272
//
7373
// Check to see the thresholds are non-zero to avoid logging errors with small
7474
// slot times (e.g., during testing)
75-
let crit_threshold = chain.slot_clock.unagg_attestation_production_delay();
76-
let error_threshold = crit_threshold / 2;
77-
if delay >= crit_threshold {
78-
crit!(
75+
let too_late_threshold = chain.slot_clock.unagg_attestation_production_delay();
76+
let delayed_threshold = too_late_threshold / 2;
77+
if delay >= too_late_threshold {
78+
error!(
7979
log,
8080
"Block was broadcast too late";
8181
"msg" => "system may be overloaded, block likely to be orphaned",
8282
"delay_ms" => delay.as_millis(),
8383
"slot" => block.slot(),
8484
"root" => ?root,
8585
)
86-
} else if delay >= error_threshold {
86+
} else if delay >= delayed_threshold {
8787
error!(
8888
log,
8989
"Block broadcast was delayed";

0 commit comments

Comments
 (0)