Skip to content

Commit 8787e71

Browse files
committed
Remove snapshot cache related code (#5661)
Squashed commit of the following: commit 1378a62 Author: Michael Sproul <[email protected]> Date: Tue Apr 30 17:02:25 2024 +1000 Add state cache CLI tests commit 470134b Author: Michael Sproul <[email protected]> Date: Tue Apr 30 16:43:07 2024 +1000 Remove cache miss comment entirely commit 65eee99 Author: Michael Sproul <[email protected]> Date: Tue Apr 30 16:41:28 2024 +1000 Fix default state cache size in docs commit 64db49a Author: Jimmy Chen <[email protected]> Date: Tue Apr 30 11:51:10 2024 +1000 Remove snapshot cache and other references.
1 parent 791c500 commit 8787e71

File tree

6 files changed

+16
-537
lines changed

6 files changed

+16
-537
lines changed

beacon_node/beacon_chain/src/beacon_chain.rs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4415,12 +4415,6 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
44154415
if cached_head.head_block_root() == parent_block_root {
44164416
(Cow::Borrowed(head_state), cached_head.head_state_root())
44174417
} else {
4418-
info!(
4419-
self.log,
4420-
"Missed snapshot cache during withdrawals calculation";
4421-
"slot" => proposal_slot,
4422-
"parent_block_root" => ?parent_block_root
4423-
);
44244418
let block = self
44254419
.get_blinded_block(&parent_block_root)?
44264420
.ok_or(Error::MissingBeaconBlock(parent_block_root))?;

beacon_node/beacon_chain/src/metrics.rs

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,18 +32,11 @@ lazy_static! {
3232
"beacon_block_processing_successes_total",
3333
"Count of blocks processed without error"
3434
);
35+
// Keeping the existing "snapshot_cache" metric name as it would break existing dashboards
3536
pub static ref BLOCK_PROCESSING_SNAPSHOT_CACHE_SIZE: Result<IntGauge> = try_create_int_gauge(
3637
"beacon_block_processing_snapshot_cache_size",
3738
"Count snapshots in the snapshot cache"
3839
);
39-
pub static ref BLOCK_PROCESSING_SNAPSHOT_CACHE_MISSES: Result<IntCounter> = try_create_int_counter(
40-
"beacon_block_processing_snapshot_cache_misses",
41-
"Count of snapshot cache misses"
42-
);
43-
pub static ref BLOCK_PROCESSING_SNAPSHOT_CACHE_CLONES: Result<IntCounter> = try_create_int_counter(
44-
"beacon_block_processing_snapshot_cache_clones",
45-
"Count of snapshot cache clones"
46-
);
4740
pub static ref BLOCK_PROCESSING_TIMES: Result<Histogram> =
4841
try_create_histogram("beacon_block_processing_seconds", "Full runtime of block processing");
4942
pub static ref BLOCK_PROCESSING_BLOCK_ROOT: Result<Histogram> = try_create_histogram(

0 commit comments

Comments
 (0)