Skip to content

Commit 80a5353

Browse files
committed
Remove some stale FIXMEs/typos
1 parent bb23f2a commit 80a5353

File tree

3 files changed

+1
-6
lines changed

3 files changed

+1
-6
lines changed

beacon_node/beacon_chain/src/schema_change/migration_schema_v24.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,7 @@ pub fn upgrade_to_v24<T: BeaconChainTypes>(
345345

346346
// Store immediately so that future diffs can load and diff from it.
347347
let mut ops = vec![];
348-
// We must commit the hot state summary immediatelly, otherwise we can't diff
348+
// We must commit the hot state summary immediately, otherwise we can't diff
349349
// against it and future writes will fail. That's why we write the new hot
350350
// summaries in a different column to have both new and old data present at
351351
// once. Otherwise if the process crashes during the migration the database will

beacon_node/beacon_chain/tests/store_tests.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3185,7 +3185,6 @@ async fn schema_downgrade_to_min_version_full_node_per_epoch_diffs() {
31853185
}
31863186

31873187
// Schema upgrade/downgrade on a full node with dense per-slot diffs.
3188-
// FIXME(tree-states): this will panic
31893188
#[tokio::test]
31903189
async fn schema_downgrade_to_min_version_full_node_dense_diffs() {
31913190
schema_downgrade_to_min_version(

beacon_node/store/src/hot_cold_store.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1662,7 +1662,6 @@ impl<E: EthSpec, Hot: ItemStore<E>, Cold: ItemStore<E>> HotColdDB<E, Hot, Cold>
16621662

16631663
match self.hot_storage_strategy(slot)? {
16641664
StorageStrategy::Snapshot => {
1665-
// FIXME(tree-states): rename error
16661665
let Some(state) = self.load_hot_state_as_snapshot(state_root)? else {
16671666
let existing_snapshots = self.load_hot_state_snapshot_roots()?;
16681667
// TODO(hdiff): this log is for debug and can include a very long list of roots,
@@ -3483,9 +3482,6 @@ pub fn get_ancestor_state_root<'a, E: EthSpec, Hot: ItemStore<E>, Cold: ItemStor
34833482
// traversing the sparse portion of the hdiff grid (prior to the split slot). It is also
34843483
// necessary for the v24 schema migration on archive nodes, where there isn't yet any grid
34853484
// to traverse.
3486-
//
3487-
// FIXME(tree-states): still need to add logic below to somehow traverse the grid on non-archive
3488-
// nodes.
34893485
if target_slot < split.slot && target_slot >= state_upper_limit {
34903486
drop(split);
34913487
return store

0 commit comments

Comments
 (0)