Skip to content

Commit db3526c

Browse files
Electronic-Wasteshashank-iitbhu
authored andcommitted
fix: remove the dependency of protocmp in google.golang.org/protobuf/testing/protocmp. (kubeflow#2391)
Signed-off-by: Electronic-Waste <[email protected]>
1 parent 7fd1672 commit db3526c

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/metricscollector/v1beta1/file-metricscollector/file-metricscollector_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import (
2727
commonv1beta1 "github.com/kubeflow/katib/pkg/apis/controller/common/v1beta1"
2828
v1beta1 "github.com/kubeflow/katib/pkg/apis/manager/v1beta1"
2929
"github.com/kubeflow/katib/pkg/controller.v1beta1/consts"
30-
"google.golang.org/protobuf/testing/protocmp"
3130
)
3231

3332
func TestCollectObservationLog(t *testing.T) {
@@ -321,7 +320,8 @@ invalid INFO {metricName: loss, metricValue: 0.3634}`,
321320
if diff := cmp.Diff(test.wantError, err, cmpopts.EquateErrors()); len(diff) != 0 {
322321
t.Errorf("Unexpected error (-want,+got):\n%s", diff)
323322
}
324-
if diff := cmp.Diff(test.expected, actual, protocmp.Transform()); len(diff) != 0 {
323+
observationLogCmpOpts := cmpopts.IgnoreUnexported(v1beta1.ObservationLog{}, v1beta1.MetricLog{}, v1beta1.Metric{})
324+
if diff := cmp.Diff(test.expected, actual, observationLogCmpOpts); len(diff) != 0 {
325325
t.Errorf("Unexpected parsed result (-want,+got):\n%s", diff)
326326
}
327327
})

0 commit comments

Comments
 (0)