|
1 |
| -<!-- Thank you for your contribution! We appreciate it. The following guidelines will help improve your pull request and facilitate feedback. If anything is unclear, don't hesitate to submit your pull request and ask the maintainers for assistance. --> |
| 1 | +<!-- Thank you for your contribution! Please follow these guidelines to enhance your pull request. If anything is unclear, submit your PR and reach out to maintainers for assistance. Join our Slack community at https://slack.sglang.ai to discuss further. --> |
2 | 2 |
|
3 | 3 | ## Motivation
|
4 | 4 |
|
5 |
| -<!-- Explain the purpose of this PR and the goals it aims to achieve. --> |
| 5 | +<!-- Describe the purpose and goals of this pull request. --> |
6 | 6 |
|
7 | 7 | ## Modifications
|
8 | 8 |
|
9 |
| -<!-- Describe the changes made in this PR. --> |
| 9 | +<!-- Detail the changes made in this pull request. --> |
10 | 10 |
|
11 |
| -## Accuracy Test |
| 11 | +## Accuracy Tests |
12 | 12 |
|
13 |
| -<!-- If this PR affects model-side code (e.g., kernels, model architecture), please provide accuracy test results. Ref: https://docs.sglang.ai/references/accuracy_evaluation.html --> |
| 13 | +<!-- If this pull request affects model outputs (e.g., changes to the kernel or model forward code), provide accuracy test results. --> |
14 | 14 |
|
15 |
| -## Benchmark & Profiling |
| 15 | +## Benchmarking and Profiling |
16 | 16 |
|
17 |
| -<!-- If this PR is expected to impact performance, please provide benchmark and profiling results. Ref: https://docs.sglang.ai/references/benchmark_and_profiling.html --> |
| 17 | +<!-- If this pull request impacts inference speed, provide benchmarking and profiling results. --> |
18 | 18 |
|
19 | 19 | ## Checklist
|
20 | 20 |
|
21 |
| -- [ ] Format your code according to the [Code Formatting with Pre-Commit](https://docs.sglang.ai/references/contribution_guide.html#code-formatting-with-pre-commit). |
22 |
| -- [ ] Add unit tests as outlined in the [Running Unit Tests](https://docs.sglang.ai/references/contribution_guide.html#running-unit-tests-adding-to-ci). |
23 |
| -- [ ] Update documentation / docstrings / example tutorials as needed, according to [Writing Documentation](https://docs.sglang.ai/references/contribution_guide.html#writing-documentation-running-docs-ci). |
24 |
| -- [ ] Provide throughput / latency benchmark results and accuracy evaluation results as needed, according to [Benchmark and Profiling](https://docs.sglang.ai/references/benchmark_and_profiling.html) and [Accuracy Results](https://docs.sglang.ai/references/accuracy_evaluation.html). |
25 |
| -- [ ] For reviewers: If you haven't made any contributions to this PR and are only assisting with merging the main branch, please remove yourself as a co-author when merging the PR. |
26 |
| -- [ ] Please feel free to join our Slack channel at https://slack.sglang.ai to discuss your PR. |
| 21 | +- [ ] Format your code according to the [Code formatting with pre-commit](https://docs.sglang.ai/references/contribution_guide.html#code-formatting-with-pre-commit). |
| 22 | +- [ ] Add unit tests according to the [Running and adding unit tests](https://docs.sglang.ai/references/contribution_guide.html#running-unit-tests-adding-to-ci). |
| 23 | +- [ ] Update documentation according to [Writing documentations](https://docs.sglang.ai/references/contribution_guide.html#writing-documentation-running-docs-ci). |
| 24 | +- [ ] Provide accuracy and speed benchmark results according to [Testing the accuracy](https://docs.sglang.ai/references/contribution_guide.html#testing-the-accuracy) and [Benchmark and profiling]() |
0 commit comments