depend on lightecc

Author: serengil

README.md

@@ -236,19 +236,17 @@ ECC is a powerful public-key cryptosystem based on the algebraic structure of el
 In LightPHE, the [Elliptic Curve ElGamal](https://sefiks.com/2018/08/21/elliptic-curve-elgamal-encryption/) scheme is implemented, offering a secure and efficient homomorphic encryption option.
 
 ```python
-forms = ["weierstass", "edwards", "koblitz"]
-
 phe = LightPHE(
     algorithm_name="EllipticCurve-ElGamal",
-    form=forms[1],
+    form="edwards", # or weierstrass, koblitz
 )
 ```
 
 One of the crucial factors that define the security level of an elliptic curve cryptosystem is the order of the curve. The order of a curve is the number of points on the curve, and it directly influences the strength of the encryption. A higher order typically corresponds to a stronger cryptosystem, making it more resistant to cryptographic attacks.
 
 Each curve in LightPHE has a specific order, which is carefully chosen to balance performance and security. By selecting an elliptic curve with a larger order, you increase the security of your cryptographic system, but this may come with a trade-off in computational efficiency. Therefore, choosing the appropriate curve order is a crucial decision based on your application’s security and performance requirements.
 
-See [`curves`](https://github.com/serengil/LightPHE/tree/master/lightphe/elliptic_curve_forms) page for a list of all supported forms, curves and their details.
+See [`curves`](https://github.com/serengil/LightECC) page for a list of all supported forms, curves and their details.
 
 ### Vector Embeddings and Tensors
 

lightphe/__init__.py

@@ -9,13 +9,16 @@
 
 # 3rd party dependencies
 from tqdm import tqdm
+from lightecc.interfaces.elliptic_curve import EllipticCurvePoint
+from lightecc.forms.weierstrass import Weierstrass
+from lightecc.forms.edwards import TwistedEdwards
+from lightecc.forms.koblitz import Koblitz
 
 # project dependencies
 from lightphe.models.Homomorphic import Homomorphic
 from lightphe.models.Ciphertext import Ciphertext
 from lightphe.models.Algorithm import Algorithm
 from lightphe.models.Tensor import Fraction, EncryptedTensor
-from lightphe.models.EllipticCurve import EllipticCurvePoint
 from lightphe.commons import phe_utils
 from lightphe.commons.logger import Logger
 
@@ -29,9 +32,6 @@
 from lightphe.cryptosystems.NaccacheStern import NaccacheStern
 from lightphe.cryptosystems.GoldwasserMicali import GoldwasserMicali
 from lightphe.cryptosystems.EllipticCurveElGamal import EllipticCurveElGamal
-from lightphe.elliptic_curve_forms.weierstrass import Weierstrass
-from lightphe.elliptic_curve_forms.edwards import TwistedEdwards
-from lightphe.elliptic_curve_forms.koblitz import Koblitz
 
 
 # pylint: disable=eval-used, simplifiable-if-expression, too-few-public-methods
@@ -465,44 +465,3 @@ def encrypt_float(
         logger.error(f"Exception while running encrypt_float: {str(err)}")
         logger.error(traceback.format_exc())
         raise err
-
-
-class ECC:
-    __version__ = VERSION
-
-    def __init__(
-        self, form_name: Optional[str] = None, curve_name: Optional[str] = None
-    ):
-        """
-        Construct an Elliptic Curve over a finite field (prime or binary)
-        Args:
-            form_name (str): specifies the form of the elliptic curve.
-                Options: 'weierstrass' (default), 'edwards', 'koblitz'.
-            curve_name (str): specifies the elliptic curve to use.
-                Options:
-                 - e.g. ed25519, ed448 for edwards form
-                 - e.g. secp256k1 for weierstrass form
-                 - e.g. k-409 for koblitz form
-                List of all available curves:
-                    github.com/serengil/LightPHE/blob/master/lightphe/elliptic_curve_forms/README.md
-        """
-        if form_name is None or form_name == "weierstrass":
-            self.curve = Weierstrass(curve=curve_name)
-        elif form_name in "edwards":
-            self.curve = TwistedEdwards(curve=curve_name)
-        elif form_name in "koblitz":
-            self.curve = Koblitz(curve=curve_name)
-        else:
-            raise ValueError(f"unimplemented curve form - {form_name}")
-
-        # base point
-        self.G = EllipticCurvePoint(self.curve.G[0], self.curve.G[1], self.curve)
-
-        # order of the curve
-        self.n = self.curve.n
-
-        # point at infinity or neutral / identity element
-        self.O = EllipticCurvePoint(self.curve.O[0], self.curve.O[1], self.curve)
-
-        # modulo
-        self.modulo = self.curve.modulo

lightphe/commons/binary_operations.py

@@ -2,9 +2,12 @@
 import random
 from typing import Optional
 
+# 3rd party dependencies
+from lightecc import LightECC as ECC
+from lightecc.interfaces.elliptic_curve import EllipticCurvePoint
+
 # project dependencies
 from lightphe.models.Homomorphic import Homomorphic
-from lightphe.models.EllipticCurve import EllipticCurvePoint
 from lightphe.commons.logger import Logger
 
 logger = Logger(module="lightphe/cryptosystems/EllipticCurveElGamal.py")
@@ -40,9 +43,6 @@ def __init__(
                  - secp256k1 for weierstrass form
                 This parameter is only used if `algorithm_name` is 'EllipticCurve-ElGamal'.
         """
-        # to avoid circular import, import ECC class here
-        from lightphe import ECC
-
         self.ecc = ECC(form_name=form, curve_name=curve)
 
         self.keys = keys or self.generate_keys(key_size or self.ecc.n.bit_length())